Closed Bug 1403899 Opened 3 years ago Closed 3 years ago

Migrate browser_webconsole_block_mixedcontent_securityerrors.js to new frontend

Categories

(DevTools :: Console, enhancement, P3)

enhancement

Tracking

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Priority: -- → P3
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Comment on attachment 8927761 [details]
Bug 1403899 - Enable browser_webconsole_block_mixedcontent_securityerrors.js in new console frontend; .

https://reviewboard.mozilla.org/r/199038/#review204156

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_block_mixedcontent_securityerrors.js:22
(Diff revision 1)
>  "use strict";
>  
>  const TEST_URI = "https://example.com/browser/devtools/client/webconsole/" +
> -                 "test/test-mixedcontent-securityerrors.html";
> -const LEARN_MORE_URI = "https://developer.mozilla.org/docs/Web/Security/" +
> -                       "Mixed_content" + DOCS_GA_PARAMS;
> +  "new-console-output/test/mochitest/test-mixedcontent-securityerrors.html";
> +const LEARN_MORE_URI =
> +  "https://developer.mozilla.org/docs/Web/Security/Mixed_content" + DOCS_GA_PARAMS;

Where is `DOCS_GA_PARAMS` defined?
Attachment #8927761 - Flags: review?(odvarko) → review-
It comes from head.js. It is added in https://hg.mozilla.org/integration/autoland/diff/3dac33fd437c/devtools/client/webconsole/new-console-output/test/mochitest/head.js (on autoland at the moment, not landed yet on m-c)
Attachment #8927761 - Flags: review- → review?(odvarko)
Comment on attachment 8927761 [details]
Bug 1403899 - Enable browser_webconsole_block_mixedcontent_securityerrors.js in new console frontend; .

https://reviewboard.mozilla.org/r/199038/#review204166

I see, r+ assuming try is green.

Thanks Nicolas!
Honza
Attachment #8927761 - Flags: review?(odvarko) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d720dddd8e4e
Enable browser_webconsole_block_mixedcontent_securityerrors.js in new console frontend; r=Honza.
https://hg.mozilla.org/mozilla-central/rev/d720dddd8e4e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.