1403899 - Migrate browser_webconsole_block_mixedcontent_securityerrors.js to new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1403899 - Enable browser_webconsole_block_mixedcontent_securityerrors.js in new console frontend; .

Review commit: https://reviewboard.mozilla.org/r/199038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199038/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8927761 [details]
Bug 1403899 - Enable browser_webconsole_block_mixedcontent_securityerrors.js in new console frontend; .

https://reviewboard.mozilla.org/r/199038/#review204156

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_block_mixedcontent_securityerrors.js:22
(Diff revision 1)
>  "use strict";
>  
>  const TEST_URI = "https://example.com/browser/devtools/client/webconsole/" +
> -                 "test/test-mixedcontent-securityerrors.html";
> -const LEARN_MORE_URI = "https://developer.mozilla.org/docs/Web/Security/" +
> -                       "Mixed_content" + DOCS_GA_PARAMS;
> +  "new-console-output/test/mochitest/test-mixedcontent-securityerrors.html";
> +const LEARN_MORE_URI =
> +  "https://developer.mozilla.org/docs/Web/Security/Mixed_content" + DOCS_GA_PARAMS;

Where is `DOCS_GA_PARAMS` defined?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

It comes from head.js. It is added in https://hg.mozilla.org/integration/autoland/diff/3dac33fd437c/devtools/client/webconsole/new-console-output/test/mochitest/head.js (on autoland at the moment, not landed yet on m-c)

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8927761 [details]
Bug 1403899 - Enable browser_webconsole_block_mixedcontent_securityerrors.js in new console frontend; .

https://reviewboard.mozilla.org/r/199038/#review204166

I see, r+ assuming try is green.

Thanks Nicolas!
Honza

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d720dddd8e4e
Enable browser_webconsole_block_mixedcontent_securityerrors.js in new console frontend; r=Honza.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d720dddd8e4e