1403905 - Icon of bookmarks toolbar dropzone has no vertical margin

Status: NEW

(Firefox :: Theme, defect, P4)

Description

[Valentina Claudia Ona]

Attachment: a.bmp

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID 20170927100120

[Affected platforms]: Windows 10 x64, Windows 7 x64, Mac OS X 10.12, Ubuntu 16.04
[Affected versions]: Nightly 58.0a1

[Steps to reproduce]:

1.Launch Nightly 58.0a1
2.Enabled Bookmark toolbar 
3.Go to Customize

[Expected results]: Icon of bookmark toolbar dropzone should have horizontally padding

[Actual results]: Icon of bookmark toolbar dropzone does not have horizontally padding

[Note]: Please see the attachment.

Comment 1

[[:Towkir] Ahmed]

Attachment: bookmarks-toolbar-dropzone-icon-on-linux.png

Looks like windows has a better look than Linux.
Here is mine.
What do you say about it Dao ?
If you suggest something, i could take this

Comment 2

[Dão Gottwald [:dao]]

(In reply to [:Towkir] Ahmed from comment #1)
> Created attachment 8913196 [details]
> bookmarks-toolbar-dropzone-icon-on-linux.png
> 
> Looks like windows has a better look than Linux.
> Here is mine.
> What do you say about it Dao ?
> If you suggest something, i could take this

Yeah, the horizontal padding looks fine to me on Windows (and not too bad on Linux either). I don't see the problem in attachment 8913193 [details]. Valentina?

Comment 3

[Valentina Claudia Ona]

Attachment: bookmark.bmp

The distances between the icon and edge (above and below) do not exist, I could say there is no pixel between edge and icon
Please see the attachment.

Comment 4

[Dão Gottwald [:dao]]

Fixing the summary accordingly.

Comment 5

[Eddward]

Attachment: BT dropzone specs vs actual.png

Comment 6

[Dão Gottwald [:dao]]

As mentioned in bug 1394933 comment 12, the height is currently expected. I think it's too late to come up with a solution here in time for Firefox 57, so I'll remove the photon-visual tag.