Open Bug 1403905 Opened 3 years ago Updated 3 years ago

Icon of bookmarks toolbar dropzone has no vertical margin

Categories

(Firefox :: Theme, defect, P4)

defect

Tracking

()

People

(Reporter: valentina.ona, Unassigned)

Details

Attachments

(4 files)

Attached image a.bmp
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID 20170927100120

[Affected platforms]: Windows 10 x64, Windows 7 x64, Mac OS X 10.12, Ubuntu 16.04
[Affected versions]: Nightly 58.0a1

[Steps to reproduce]:

1.Launch Nightly 58.0a1
2.Enabled Bookmark toolbar 
3.Go to Customize

[Expected results]: Icon of bookmark toolbar dropzone should have horizontally padding

[Actual results]: Icon of bookmark toolbar dropzone does not have horizontally padding

[Note]: Please see the attachment.
Looks like windows has a better look than Linux.
Here is mine.
What do you say about it Dao ?
If you suggest something, i could take this
Flags: needinfo?(dao+bmo)
Whiteboard: [reserve-photon-visual] → [photon-visual][triage]
(In reply to [:Towkir] Ahmed from comment #1)
> Created attachment 8913196 [details]
> bookmarks-toolbar-dropzone-icon-on-linux.png
> 
> Looks like windows has a better look than Linux.
> Here is mine.
> What do you say about it Dao ?
> If you suggest something, i could take this

Yeah, the horizontal padding looks fine to me on Windows (and not too bad on Linux either). I don't see the problem in attachment 8913193 [details]. Valentina?
Flags: needinfo?(dao+bmo) → needinfo?(valentina.ona)
Attached image bookmark.bmp
The distances between the icon and edge (above and below) do not exist, I could say there is no pixel between edge and icon
Please see the attachment.
Flags: needinfo?(valentina.ona)
Fixing the summary accordingly.
Summary: Icon of bookmarks toolbar dropzone has no horizontally padding → Icon of bookmarks toolbar dropzone has no vertical margin
As mentioned in bug 1394933 comment 12, the height is currently expected. I think it's too late to come up with a solution here in time for Firefox 57, so I'll remove the photon-visual tag.
Priority: -- → P4
Whiteboard: [photon-visual][triage]
You need to log in before you can comment on or make changes to this bug.