Closed Bug 1403910 Opened 2 years ago Closed 2 years ago

Migrate browser_webconsole_bug_583816_No_input_and_Tab_key_pressed.js ti the new frontend

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(firefox57 wontfix, firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

the new frontend also uses an html jsterm, in which the "focused" attribute is not set.
the focus should be tested in another way
the focus can be tested with the `hasFocus` helper function
Priority: -- → P3
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment on attachment 8917834 [details]
Bug 1403910 - Enable and rename browser_webconsole_No_input_and_Tab_key_pressed.js on the new console frontend;

https://reviewboard.mozilla.org/r/188786/#review194354

Works well for me.

R+ (tested with --verify on Win10)

Thanks Nicolas!
Honza
Attachment #8917834 - Flags: review?(odvarko) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84907247d8f5
Enable and rename browser_webconsole_No_input_and_Tab_key_pressed.js on the new console frontend; r=Honza
https://hg.mozilla.org/mozilla-central/rev/84907247d8f5
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.