1403914 - WASM_HUGE_MEMORY is defined after its first use

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P1)

Description

[Lars T Hansen [:lth]]

WASM_HUGE_MEMORY is defined in WasmTypes.h but only after there's an #ifdef (actually an #ifndef) that depends on it: it guards TlsData::boundsCheckLimit.

This has probably been benign so far because no code breaks if I move the definition to the top of WasmTypes.h, but I tripped over this when trying to implement explicit bounds checking for atomics on x64, all my tests were failing because this field is zero on this platform, while it really should not have been available at all.

Config options like these that affect many files probably should not be in individual headers if it can be helped, but should instead be set up in eg moz.build.

Comment 1

[Lars T Hansen [:lth]]

Attachment: bug1403914-define-wasm-huge-memory.patch

Move the definition to moz.build and add a sanity check in WasmTypes.cpp to check that the configuration is what we expect.

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8913201 [details] [diff] [review]
bug1403914-define-wasm-huge-memory.patch

Review of attachment 8913201 [details] [diff] [review]:
-----------------------------------------------------------------

Oof good one, and *much* better fix.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67f7280bb9ff
define WASM_HUGE_MEMORY so it's visible to all. r=luke

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/67f7280bb9ff