1403947 - The context menu is not dismissed when a tile is dragged

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: context menu not dismissed.gif

[Affected versions]:
- Firefox 57 and up

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Steps to reproduce]:
1. Start the browser and open a New Tab.
2. Click the context menu button for one of the tiles.
3. Drag a different tile and observe the context menu.
 
[Expected results]:
- The context menu is dismissed.

[Actual results]:
- The context menu stays in it's place.

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[u594638]

Just following up here from my post on the GitHub issue (https://github.com/mozilla/activity-stream/issues/3624#issuecomment-350343893)! I'd love to tackle this bug if it's still available :)

Comment 2

[Ed Lee :Mardak]

kunal12422 originally requested to work on this bug. k88hudson, is that still active or should Sean take this bug?

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

This should be fixed by https://github.com/mozilla/activity-stream/pull/3902

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

Fixed in https://github.com/mozilla/activity-stream/commit/313a951204c17c1c9a0b301dff3357d8e7c6d615

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/7d9c675dabf5

Comment 6

[Ciprian Muresan [:cmuresan], Ecosystem QA]

The issue is still reproducible on the latest Nightly 59.0a1 (Build ID 20180110100224) on Arch Linux x64, Ubuntu 16.04 x86, Mac 10.12.6 and Windows 10 x64.
While the context menu is dismissed if you drag the same Top Site, it is not dismissed if you drag a different Top Site.

Comment 7

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: context menu is not dismissed.gif

Attached a screen recording of the issue.

Comment 8

[Ed Lee :Mardak]

I believe this was fixed by bug 1430132 (and that other bug was not actually fixed).

Comment 9

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/8ae1faf4646f

Comment 10

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Nightly build (Build ID 	20180121220252) using Windows 10 x64, Mac 10.12 and Ubuntu 14.04.