Closed Bug 1403989 Opened 2 years ago Closed 2 years ago

Invert monochromatic Places icons in Menu Bar Menus

Categories

(Core :: Widget: Cocoa, enhancement, P3)

All
macOS
enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: shorlander, Assigned: mstange)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image Nightly vs. Finder
We should invert our monochromatic Places icons when you hover Menu Bar menu items for increased visibility and OS consistency.
Priority: -- → P3
Blocks: 1414368
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Comment on attachment 8913972 [details]
Bug 1403989 - Automatically treat black menu icons as templates, so that they get drawn inverted in hovered menuitems.

https://reviewboard.mozilla.org/r/185346/#review242768
Attachment #8913972 - Flags: review?(spohl.mozilla.bugs) → review+
Comment on attachment 8913972 [details]
Bug 1403989 - Automatically treat black menu icons as templates, so that they get drawn inverted in hovered menuitems.

https://reviewboard.mozilla.org/r/185346/#review243096

you might add a comment about being broken on big endian. The right solution here is probably to have constants for [RGB]_COMPONENT that depend on the endianess, but whatever...
Attachment #8913972 - Flags: review+
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/079e73b36f8b
Automatically treat black menu icons as templates, so that they get drawn inverted in hovered menuitems. r=jrmuizel,spohl
https://hg.mozilla.org/mozilla-central/rev/079e73b36f8b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: mozilla58 → mozilla61
You need to log in before you can comment on or make changes to this bug.