Closed
Bug 1403989
Opened 7 years ago
Closed 6 years ago
Invert monochromatic Places icons in Menu Bar Menus
Categories
(Core :: Widget: Cocoa, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: shorlander, Assigned: mstange)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
We should invert our monochromatic Places icons when you hover Menu Bar menu items for increased visibility and OS consistency.
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8913972 [details] Bug 1403989 - Automatically treat black menu icons as templates, so that they get drawn inverted in hovered menuitems. https://reviewboard.mozilla.org/r/185346/#review242768
Attachment #8913972 -
Flags: review?(spohl.mozilla.bugs) → review+
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8913972 [details] Bug 1403989 - Automatically treat black menu icons as templates, so that they get drawn inverted in hovered menuitems. https://reviewboard.mozilla.org/r/185346/#review243096 you might add a comment about being broken on big endian. The right solution here is probably to have constants for [RGB]_COMPONENT that depend on the endianess, but whatever...
Attachment #8913972 -
Flags: review+
Comment hidden (mozreview-request) |
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/079e73b36f8b Automatically treat black menu icons as templates, so that they get drawn inverted in hovered menuitems. r=jrmuizel,spohl
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/079e73b36f8b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: mozilla58 → mozilla61
Updated•6 years ago
|
status-firefox58:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•