1404022 - setAttributeNode() is incorrectly deprecated.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[kevin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce:

I set an attribute on a dom object using setAttributeNode().


Actual results:

Firefox console reported: "Use of setAttributeNode() is deprecated. Use setAttribute() instead."


Expected results:

No deprecation notice should have been issued. setAttributeNode() is part of the current standard.

https://dom.spec.whatwg.org/#dom-element-setattributenode

Comment 1

[kevin]

Also no other browser marks this function as deprecated.

Comment 2

[(no longer active)]

These were marked as deprecated in bug 661327.

bz, anne, do we stil want to pursue removing them some day?

Comment 3

[Anne (:annevk)]

No, time to give up. Thanks kevin for reporting this.

Comment 4

[(no longer active)]

We also have deprecation warnings for getAttributeNode/getAttributeNodeNS/removeAttributeNode/createAttribute/createAttributeNS.  If those also need to be revised we should file follow-up bugs.

Comment 5

[(no longer active)]

Attachment: Remove the deprecation warnings for Element.setAttribute/setAttributeNS

Comment 6

[(no longer active)]

(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #4)
> We also have deprecation warnings for
> getAttributeNode/getAttributeNodeNS/removeAttributeNode/createAttribute/
> createAttributeNS.

Anne confirmed on IRC.  Filed bug 1406493 as a follow-up.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e136f53974d8
Remove the deprecation warnings for Element.setAttribute/setAttributeNS; r=baku

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e136f53974d8

Comment 9

[Chris Mills [:cmills]]

I've checked the docs, and we don't mention it being deprecated anywhere. We just say that setAttribute() is the more common way of setting attributes.