Closed
Bug 1404029
Opened 7 years ago
Closed 7 years ago
Clean up CheckHasNoSuchProperty
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(2 files)
2.26 KB,
patch
|
tcampbell
:
review+
|
Details | Diff | Splinter Review |
13.11 KB,
patch
|
tcampbell
:
review+
|
Details | Diff | Splinter Review |
Noticed this while reviewing bug 1357759 and couldn't resist fixing. CheckHasNoSuchProperty has some optional outparams that are unused now (since the CacheIR conversion of the callers).
Attachment #8913317 -
Flags: review?(tcampbell)
Assignee | ||
Comment 1•7 years ago
|
||
We could also move CheckHasNoSuchOwnProperty and CheckHasNoSuchProperty into CacheIR.cpp (as static functions), as they are only called from there. I can post a second patch for that later.
Comment 2•7 years ago
|
||
Comment on attachment 8913317 [details] [diff] [review] Patch Review of attachment 8913317 [details] [diff] [review]: ----------------------------------------------------------------- Good find! No callers used those.
Attachment #8913317 -
Flags: review?(tcampbell) → review+
Assignee | ||
Comment 3•7 years ago
|
||
This just moves a bunch of functions from SharedIC/BaselineIC into CacheIR.cpp and makes them static. CheckForTypedObjectWithDetachedStorage I inlined into the caller.
Attachment #8913594 -
Flags: review?(tcampbell)
Comment 4•7 years ago
|
||
Comment on attachment 8913594 [details] [diff] [review] Move functions to CacheIR.cpp Review of attachment 8913594 [details] [diff] [review]: ----------------------------------------------------------------- Good cleanup.
Attachment #8913594 -
Flags: review?(tcampbell) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/89c1671be86f part 1 - Remove unused outparams from CheckHasNoSuchProperty and simplify the code. r=tcampbell https://hg.mozilla.org/integration/mozilla-inbound/rev/58e4bf0244e8 part 2 - Move some functions from SharedIC/BaselineIC files to CacheIR.cpp and make them static. r=tcampbell
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/89c1671be86f https://hg.mozilla.org/mozilla-central/rev/58e4bf0244e8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•