Closed Bug 1404065 Opened 6 years ago Closed 6 years ago

Make sync buttons match Photon style guide

Categories

(Firefox :: Sync, enhancement, P2)

Product:
Firefox
Component:
Sync
Version:
55 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: rfeeley, Assigned: eoger)

Details

Attachments

(2 files)

sign-in-to-sync.png
44.07 KB, image/png
Details
Bug 1404065 - Update Synced Tabs buttons to photon style.
59 bytes, text/x-review-board-request
markh
: review+
Details 
Now that Photon has a recommended button style, we should use it for Firefox unverified menu.

We should use the Primary style described here.
http://design.firefox.com/photon/components/buttons.html
Attached image sign-in-to-sync.png — 
Priority: -- → P2
Assignee: nobody → eoger

    
    

    
      
  


  

    
    

    
  
Comment on attachment 8914888 [details]
Bug 1404065 - Update Synced Tabs buttons to photon style.

https://reviewboard.mozilla.org/r/186146/#review191310

LGTM, thanks. Please ensure rfeeley approves!

        Attachment #8914888 -
        Flags: review?(markh) → review+

    
    

    
  
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fcc3bffcdd80
Update Synced Tabs buttons to photon style. r=markh

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/fcc3bffcdd80
Status: NEW → RESOLVED
Closed: 6 years ago

          status-firefox58:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58

    
    

    
  
Why did this patch mess with the font size? It shouldn't be hardcoded to a pixel value, and now undercuts the OS default font size on Ubuntu.
Flags: needinfo?(rfeeley)

    
    

    
  
Backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/f01337ed23f337c61469c085d06362e7984aa93a
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
Hi Dao: I'm not the engineer, rather the designer. What would be the correct implementation approach? font: menu; ?
Flags: needinfo?(rfeeley) → needinfo?(dao+bmo)

    
    

    
  
Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/f01337ed23f3

          status-firefox58:
          fixed → ---
Target Milestone: Firefox 58 → ---

    
    

    
  
(In reply to Ryan Feeley [:rfeeley] from comment #8)
> Hi Dao: I'm not the engineer, rather the designer.

Forwarding needinfo to Edouard...

> What would be the correct implementation approach? font: menu; ?

What's your goal with setting a font-size in the first place? The button inherits the font size by default.
Flags: needinfo?(dao+bmo) → needinfo?(eoger)

    
    

    
      
  

    
    

    
  
Re-landing this without the font-size part, rfeeley consulted with shorlander and it looks OK without the font-size.

    
  
Flags: needinfo?(eoger)

    
    

    
  
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50b7295fd3fc
Update Synced Tabs buttons to photon style. r=markh

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/50b7295fd3fc
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago

          status-firefox58:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58

          You need to log in
          before you can comment on or make changes to this bug.