Closed
Bug 1404065
Opened 7 years ago
Closed 7 years ago
Make sync buttons match Photon style guide
Categories
(Firefox :: Sync, enhancement, P2)
Tracking
()
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: rfeeley, Assigned: eoger)
Details
Attachments
(2 files)
sign-in-to-sync.png
Now that Photon has a recommended button style, we should use it for Firefox unverified menu. We should use the Primary style described here. http://design.firefox.com/photon/components/buttons.html
|
Reporter | |
Comment 1•7 years ago
|
||
|
||
Updated•7 years ago
|
Priority: -- → P2
|
|
||
Updated•7 years ago
|
Assignee: nobody → eoger
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8914888 [details] Bug 1404065 - Update Synced Tabs buttons to photon style. https://reviewboard.mozilla.org/r/186146/#review191310 LGTM, thanks. Please ensure rfeeley approves!
Attachment #8914888 -
Flags: review?(markh) → review+
Pushed by eoger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fcc3bffcdd80 Update Synced Tabs buttons to photon style. r=markh
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fcc3bffcdd80
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
||
Comment 6•7 years ago
|
||
Why did this patch mess with the font size? It shouldn't be hardcoded to a pixel value, and now undercuts the OS default font size on Ubuntu.
Flags: needinfo?(rfeeley)
|
|
||
Comment 7•7 years ago
|
||
Backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/f01337ed23f337c61469c085d06362e7984aa93a
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Reporter | |
Comment 8•7 years ago
|
||
Hi Dao: I'm not the engineer, rather the designer. What would be the correct implementation approach? font: menu; ?
Flags: needinfo?(rfeeley) → needinfo?(dao+bmo)
|
||
Comment 9•7 years ago
|
||
Merge of backout: https://hg.mozilla.org/mozilla-central/rev/f01337ed23f3
status-firefox58:
fixed → ---
Target Milestone: Firefox 58 → ---
|
|
||
Comment 10•7 years ago
|
||
(In reply to Ryan Feeley [:rfeeley] from comment #8) > Hi Dao: I'm not the engineer, rather the designer. Forwarding needinfo to Edouard... > What would be the correct implementation approach? font: menu; ? What's your goal with setting a font-size in the first place? The button inherits the font size by default.
Flags: needinfo?(dao+bmo) → needinfo?(eoger)
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 12•7 years ago
|
||
Re-landing this without the font-size part, rfeeley consulted with shorlander and it looks OK without the font-size.
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(eoger)
|
||
Comment 13•7 years ago
|
||
Pushed by eoger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/50b7295fd3fc Update Synced Tabs buttons to photon style. r=markh
|
||
Comment 14•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/50b7295fd3fc
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in
before you can comment on or make changes to this bug.
Description
•