Closed Bug 1404065 Opened 3 years ago Closed 3 years ago
Make sync buttons match Photon style guide
Now that Photon has a recommended button style, we should use it for Firefox unverified menu. We should use the Primary style described here. http://design.firefox.com/photon/components/buttons.html
Comment on attachment 8914888 [details] Bug 1404065 - Update Synced Tabs buttons to photon style. https://reviewboard.mozilla.org/r/186146/#review191310 LGTM, thanks. Please ensure rfeeley approves!
Attachment #8914888 - Flags: review?(markh) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/fcc3bffcdd80 Update Synced Tabs buttons to photon style. r=markh
Why did this patch mess with the font size? It shouldn't be hardcoded to a pixel value, and now undercuts the OS default font size on Ubuntu.
Backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/f01337ed23f337c61469c085d06362e7984aa93a
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hi Dao: I'm not the engineer, rather the designer. What would be the correct implementation approach? font: menu; ?
Flags: needinfo?(rfeeley) → needinfo?(dao+bmo)
Merge of backout: https://hg.mozilla.org/mozilla-central/rev/f01337ed23f3
(In reply to Ryan Feeley [:rfeeley] from comment #8) > Hi Dao: I'm not the engineer, rather the designer. Forwarding needinfo to Edouard... > What would be the correct implementation approach? font: menu; ? What's your goal with setting a font-size in the first place? The button inherits the font size by default.
Flags: needinfo?(dao+bmo) → needinfo?(eoger)
Re-landing this without the font-size part, rfeeley consulted with shorlander and it looks OK without the font-size.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/50b7295fd3fc Update Synced Tabs buttons to photon style. r=markh
You need to log in before you can comment on or make changes to this bug.