1404069 - Permanent solution for TCP Fast Open, depends on bug 1404061

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P1)

Description

[Dragana Damjanovic [:dragana]]

We will need to do some changes to necko if version 1 or version 2 from bug 1404061 is chosen.

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: bug_revert_bug_1363372.patch

Comment 2

[Dragana Damjanovic [:dragana]]

tfo turned off:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5919556fd120a926f22fee6da1cd4d8ffb2997fe

tfo turned on:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2d967fa6af312d83989dcdc936687f581da72b3

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8914725 [details] [diff] [review]
bug_revert_bug_1363372.patch

Review of attachment 8914725 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/nsSocketTransport2.h
@@ +169,5 @@
>      void OnSocketEvent(uint32_t type, nsresult status, nsISupports *param);
>  
>      uint64_t ByteCountReceived() override { return mInput.ByteCount(); }
>      uint64_t ByteCountSent() override { return mOutput.ByteCount(); }
> +    static void CloseSocket(PRFileDesc *aFd, bool aTelemetryEnabled);

it was a bit nicer with passing STS, but up to you if you want this patch be kind of a backout

Comment 4

[Dragana Damjanovic [:dragana]]

Attachment: bug_revert_bug_1363372.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d86a025b8ce
Revert bug 1363372. r=mayhemer

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5d86a025b8ce