1404079 - Remove nsIDOMHTMLFrameElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Continuing removal of XPCOM DOM HTML Element interfaces.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1404079 - Remove nsIDOMHTMLFrameElement;

Review commit: https://reviewboard.mozilla.org/r/185796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185796/

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8914456 [details]
Bug 1404079 - Remove nsIDOMHTMLFrameElement;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/185796/diff/1-2/

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8914456 [details]
Bug 1404079 - Remove nsIDOMHTMLFrameElement;

https://reviewboard.mozilla.org/r/185796/#review191634

r=me with the nits below

::: layout/generic/nsSubDocumentFrame.cpp:118
(Diff revision 2)
>                           nsIFrame*         aPrevInFlow)
>  {
> +  MOZ_ASSERT(aContent);
>    // determine if we are a <frame> or <iframe>
> -  nsCOMPtr<nsIDOMHTMLFrameElement> frameElem = do_QueryInterface(aContent);
> +  RefPtr<HTMLFrameElement> frameElem = HTMLFrameElement::FromContent(aContent);
>    mIsInline = frameElem ? false : true;

I know this was already here, but frameElem is actually unused.  So you could nix it altogether, and do:

    mIsInline = !aContent->IsHTMLElement(nsGkAtoms::frame);
    
or so.

::: layout/generic/nsSubDocumentFrame.cpp:288
(Diff revision 2)
>      // code used to do.
>      return ScreenIntSize(10, 10);
>    } else {
>      nsSize docSizeAppUnits;
>      nsPresContext* presContext = PresContext();
> -    nsCOMPtr<nsIDOMHTMLFrameElement> frameElem =
> +    RefPtr<HTMLFrameElement> frameElem =

GetContent can't be null here.  Also, frameElem is again unused, so you can just do an IsHTMLElement() check.

::: layout/printing/nsPrintEngine.cpp:1381
(Diff revision 2)
>  
>        // XXX If a subdocument has no onscreen presentation, there will be no PO
>        //     This is even if there should be a print presentation
>        if (po) {
>  
> -        nsCOMPtr<nsIDOMHTMLFrameElement> frame(do_QueryInterface(aContent));
> +        RefPtr<dom::HTMLFrameElement> frame = dom::HTMLFrameElement::FromContent(aContent);

"frame" is also unused; can use IsHTMLElement(nsGkAtoms::frame) here.

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8914456 [details]
Bug 1404079 - Remove nsIDOMHTMLFrameElement;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/185796/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a0d51bfe126
Remove nsIDOMHTMLFrameElement; r=bz

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7a0d51bfe126