1404080 - Add dwBuildNumber and UBR to the Windows version in the app.update.url

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement, P2)

Description

[Robert Strong (they/them - no direct email)]

https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/UpdateUtils.jsm#362

The wServicePackMajor and wServicePackMinor values are included and we should add dwBuildNumber in case it is needed at some point.

Comment 1

[Robert Strong (they/them - no direct email)]

I'm tempted to include the UBR just in case since it is trivial to include it and it can identify additional fixes that may be of interest.

https://technet.microsoft.com/en-us/windows/release-info

Comment 2

[Robert Strong (they/them - no direct email)]

catlee, in relation to balrog would it be ok to also include the ubr for the build as well?

Comment 3

[Chris AtLee [:catlee]]

I don't see why not. 302 to the expert though.

Comment 4

[[e-mail] (:bhearsum)]

Sounds like this is just another number in the already long string of numbers in OS_VERSION? If so, I don't see any reason not to send it.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

This only tries to add UBR when the Windows OS is 10 or greater. Here are a couple of examples
Windows_NT%2010.0.0.0.15063.608%20(x64)
Windows_NT%2010.0.0.0.15063.unknown%20(x64)

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 8914541 [details] [diff] [review]
patch rev1

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4320ba073ee37f3648705a8ad09cfac2bc721420

I don't think the try / catch around the readRegkey is necessary but I forgot to remove it before submitting. I'll remove it after the review, etc.

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch for checkin - removed unnecessary try / catch

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7942ddde813
Add dwBuildNumber and UBR to the Windows version in the OS_VERSION replacement for the app.update.url. r=mhowell

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f7942ddde813