Closed Bug 1404097 Opened 4 years ago Closed 4 years ago

stylo: restore assertion in MediaExpressionValue::from_css_value to expect only pixel values to be passed from Gecko

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox57 --- wontfix
firefox58 --- affected

People

(Reporter: bradwerth, Assigned: bradwerth)

References

Details

Attachments

(1 file)

The complicated landing of Bug 1376931 forces MediaExpressionValue::from_css_value to temporarily pass through both pixel and inch resolution values without conversion. After Bug 1376931 has landed, this function should be returned to its simpler form but to now only accept pixel values (unconverted).
Attachment #8913417 - Flags: review?(cam)
FWIW I think it would be fine not to worry too much about breakage in the intermediate state of Servo-side having landed but Gecko-side not landed yet, since (in the ideal case) this is only one push worth of bustage, and it's something we have to put up with often anyway.
Comment on attachment 8913417 [details]
Bug 1404097: stylo: restore MediaExpressionValue::from_css_value to only accept one type of unit (pixels).

https://reviewboard.mozilla.org/r/184748/#review190270
Attachment #8913417 - Flags: review?(cam) → review+
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/edce9959c364
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.