Open Bug 1404136 Opened 2 years ago Updated 2 years ago

Since landing of 1399498, Windows 7 and Photon result in a very inconsistent mix

Categories

(Firefox :: Theme, enhancement, P5)

enhancement

Tracking

()

People

(Reporter: clement.lefevre, Assigned: shorlander)

References

Details

(Keywords: nightly-community, Whiteboard: [mozfr-community] [reserve-photon-visual][photon-followup])

Attachments

(11 files)

[Tracking Requested - why for this release]:

After bug 1399498 did land, it resulted in inconsistencies between parts of the Chrome decored by Windows and parts decored by Firefox compared to before were appart from the three system/window buttons the whole chrome was drawn by Firefox.

I'll join many screenshots in the following comments to illustrate the issue. I tried to gather most of the Firefox and system themes combinations.
We'll start with how it was before the landing of 1399498.
Sadly I only found screenshots with light and dark theme, not default one.
Here's the light theme. We can see that the whole chrome is drawn by Firefox, and only the system buttons from the OS.
Attached image compact_dark_before.PNG
Here's the compact dark theme before landing of the patch. Both are using Aero.
Attached image classic_and_default.PNG
Classic and default theme.
Sadly, most of the classic screenshots are not exactly what the user can see, because using the Windows screenshot tool unselect the window, changing colors
Attached image classic_and_light.PNG
Classic and light theme
Attached image classic_and_dark.PNG
Classic and dark theme
Attached image basic_and_default.PNG
Attached image basic_and_light.PNG
Attached image basic_and_dark.PNG
Attached image aero_and_default.PNG
Attached image aero_and_light.PNG
Attached image aero_and_dark.PNG
So, to compare, we can see that the two first screenshots had, at least for light and dark themes a chrome that was completely drawn by Firefox and perfectly uniform, only window controls being those from the OS. This looks clean.

After 1399498 landed, chrome and window decoration is mixed between Firefox and the OS. This looks inconsistent, the most visible and shoking part being the little tab strip on the left with the arrow, to scroll tabs to the left. The right part is noticeable too altough less visible/shoking.
The same way, the Aero ones looks a little bit cleaner *but* are subect to color of the Aero theme and wallpaper or windows under Firefox's one (so, combinations can looks good, and others don't). Basic Windows theme doesn't look that good. Classic one looks even worse.

I currently have no idea what are Mozilla plans regarding support of all those combinations between Firefox's theme and Windows one but I think it would really need some thoughts and make a choice between either don't pay attention to the OS and draw the whole chrome and window decorationsinto Firefox, only using OS window buttons as the two first screenshots, either use more of the OS theme and lower the part drawn by Firefox. But mixing both like here, in my humble opinion, really lead to something that doesn't look consistent.
Whiteboard: [mozfr-community][photon-visual] → [mozfr-community] [photon-visual] [triage]
Blocks: 1399498
See Also: 1399498
Dropping the tracking flag and setting this back to UNCONFIRMED. It's not even clear whether we want to take any action here. Currently Windows 7 looks like the spec that was given by UX (minus smaller bugs): http://design.firefox.com/people/shorlander/photon/Mockups/windows-7.html

The rest is your personal opinion, not something actionable or trackable.

Because I don't want to suppress any discussion on this, I'll needinfo shorlander to decide whether this bug is a WONTFIX or if there are follow-up improvements we can make on Windows 7.

Thank you for taking the time to voice your concerns.
Status: NEW → UNCONFIRMED
Ever confirmed: false
Flags: needinfo?(shorlander)
Flags: qe-verify?
Priority: -- → P5
Whiteboard: [mozfr-community] [photon-visual] [triage] → [mozfr-community] [reserve-photon-visual]
Duplicate of this bug: 1407091
Adding this to UX triage.

Looks like there are some weird intersections between our various themes and Windows 7 in various configuration. Will need to sort through this and see if there is anything we want to do here.
Flags: needinfo?(shorlander)
Whiteboard: [mozfr-community] [reserve-photon-visual] → [mozfr-community] [reserve-photon-visual][design-decision-needed]
Flags: qe-verify? → qe-verify+
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1418796
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: DUPLICATE → ---
Sorry for the spam, marked wrong bug as dupe. Monday morning.
Status: REOPENED → NEW
Duplicate of this bug: 1418796
Duplicate of this bug: 1418637
Duplicate of this bug: 1419279
I believe you can at least restore the transparency of inactive tabs... the square ugliness of the new W10 centric theme I might be able to live with, but the opaque-ness looks Horrendous in windowed mode... And running firefox in maximized state on a Ultrawide monitor is less than pleasant...
Hi, this issue is on stable 57 with any aero enabled system.

The default theme is ok, 

https://puush.tuto-craft.com/847Q5M.png

but when you switch to another one ... uhhh.

https://puush.tuto-craft.com/478V8A.png

https://puush.tuto-craft.com/8p144i.png

https://puush.tuto-craft.com/3L4I4M.png

Please, fix that, it is just horrible ...
(In reply to skid from comment #22)
> Hi, this issue is on stable 57 with any aero enabled system.
> 
> The default theme is ok, 
> 
> https://puush.tuto-craft.com/847Q5M.png
> 
> but when you switch to another one ... uhhh.
> 
> https://puush.tuto-craft.com/478V8A.png
> 
> https://puush.tuto-craft.com/8p144i.png
> 
> https://puush.tuto-craft.com/3L4I4M.png
> 
> Please, fix that, it is just horrible ...

huh, I know this is not what you want to hear, but only your default theme looks off right now (it lacks the tab background). Are you using a userChrome.css file? Can you please file a new bug if this is reproducible with a clean profile? Thanks!
(In reply to Stephen Horlander [:shorlander] from comment #15)
> Adding this to UX triage.
> 
> Looks like there are some weird intersections between our various themes and
> Windows 7 in various configuration. Will need to sort through this and see
> if there is anything we want to do here.

Is this still on your radar? Since we've shipped this and haven't heard too many complaints, it seems to me that we should just close this as wontfix.
Flags: needinfo?(shorlander)
(In reply to Dão Gottwald [::dao] from comment #24)
> (In reply to Stephen Horlander [:shorlander] from comment #15)
> > Adding this to UX triage.
> > 
> > Looks like there are some weird intersections between our various themes and
> > Windows 7 in various configuration. Will need to sort through this and see
> > if there is anything we want to do here.
> 
> Is this still on your radar? Since we've shipped this and haven't heard too
> many complaints, it seems to me that we should just close this as wontfix.

This is mostly as designed. I still want to take a second looks to see if there are any improvements to be made.
Assignee: nobody → shorlander
Flags: needinfo?(shorlander)
Whiteboard: [mozfr-community] [reserve-photon-visual][design-decision-needed] → [mozfr-community] [reserve-photon-visual][photon-followup]
(In reply to Stephen Horlander [:shorlander] from comment #25)
> This is mostly as designed. I still want to take a second looks to see if
> there are any improvements to be made.

I really hope this is not as designed.

On Windows 10, there is an option to paint the windows captions in an accent color of your choosing.
If this options is switched on, Firefox respects it and draws the entire caption in the chosen accent color (the tabs and the area around the tabs).
If it's off, Firefox draws the entire caption in dark navy.
All in all, it looks pretty good in both cases.

On Windows 8, there is no option for an accent color applied to windows captions (which has been the case all these years before Windows 10). And Firefox on Windows 8 uses the system window caption color to draw its caption background. There is no dark navy anywhere to be seen, neither on the inactive tabs nor around them.
That looks *very good*, arguably the best look of all three OSs.

On Windows 7, there is also no option for an accent color for windows captions.
One could think Firefox would therefore do the same it does on Windows 8, blending into the system-level caption color.
Instead it does a weird mix of Windows 8 and Windows 10 behaviours: it leaves the system-defined caption color in the areas around the tabs, whether the aero glass is on or off, and it paints the inactive tabs in dark navy. It looks so out of place that it makes one feel it's a bug rather than a design choice.
You need to log in before you can comment on or make changes to this bug.