Closed Bug 1404174 Opened 3 years ago Closed 3 years ago

fsanitize=enum (ubsan) runtime errors for nsEventStatus

Categories

(Core :: Panning and Zooming, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: arthur, Assigned: arthur)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor][gfx-noted])

Attachments

(1 file)

An -fsanitize=enum run gives errors like:
[task 2017-09-25T00:24:35.119Z] 00:24:35     INFO - GECKO(1097) | /builds/worker/workspace/build/src/gfx/layers/apz/util/InputAPZContext.cpp:58:18: runtime error: load of value 2788801888, which is not a valid value for type 'nsEventStatus'

Seems to be closely related to bug 1199885 comment 101.
Looks to me like nsEventStatus_eIgnore is the way this is done in other parts of the code.
Attachment #8913492 - Flags: review?(bugmail)
Attachment #8913492 - Flags: review?(bugmail) → review+
Assignee: nobody → arthuredelstein
Priority: -- → P3
Whiteboard: [tor] → [tor][gfx-noted]
Thanks for the review.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/03f60efbf009
Fix ubsan runtime error for nsEventStatus enum. r=kats
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/03f60efbf009
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Blocks: 1404547
You need to log in before you can comment on or make changes to this bug.