1404207 - Assertion failure: false (NS_SUCCEEDED(rv)), at dom/console/ConsoleReportCollector.cpp:80

Status: RESOLVED WORKSFORME

(Core :: DOM: Service Workers, defect, P3)

Description

[Bob Clary [:bc] (inactive)]

Attachment: Linux Debug Asan Log

1. https://www.olx.co.za/cars-bakkies_c378/q-audi%20a4
   Nightly/58, Beta/57 *ASAN DEBUG* build.

2. Assertion failure: false (NS_SUCCEEDED(rv)), at /builds/worker/workspace/build/src/dom/console/ConsoleReportCollector.cpp:80
#01: mozilla::net::HttpBaseChannel::DoNotifyListener() (/builds/worker/workspace/build/src/netwerk/protocol/http/HttpBaseChannel.cpp:3280 (discriminator 1))
#02: mozilla::net::HttpAsyncAborter<mozilla::net::HttpChannelChild>::HandleAsyncAbort() (/builds/worker/workspace/build/src/netwerk/protocol/http/HttpBaseChannel.h:735)
#03: mozilla::net::HttpChannelChild::HandleAsyncAbort() (:?)
#04: mozilla::detail::RunnableMethodImpl<mozilla::net::HttpChannelChild*, void (mozilla::net::HttpChannelChild::*)(), true, (mozilla::RunnableKind)0>::Run() (:?)
#05: nsThread::ProcessNextEvent(bool, bool*) (/builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp:1040)
#06: NS_ProcessNextEvent(nsIThread*, bool) (/builds/worker/workspace/build/src/xpcom/threads/nsThreadUtils.cpp:524 (discriminator 3))
#07: mozilla::dom::workers::RuntimeService::Cleanup() (/builds/worker/workspace/build/src/dom/workers/RuntimeService.cpp:2156)
#08: mozilla::dom::workers::RuntimeService::Observe(nsISupports*, char const*, char16_t const*) (:?)

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Tom, having any clues of how come |nsresult rv = NS_NewURI(getter_AddRefs(uri), report.mSourceFileURI);| could fail even when mSourceFileURI is non-empty?

Comment 2

[Tom Tung [:tt, :ttung]]

It seems like we cannot get IOService while wanting to convert the URI from nsString to nsIURI.

From the log just before hitting the assert in attachment 8913558 [details]:

[Parent 15883, Main Thread] WARNING: cannot post event if not initialized: file /builds/worker/workspace/build/src/netwerk/protocol/http/nsHttpConnectionMgr.cpp, line 292

It shows that mSocketThreadTarget [1] hasn't been set at this time. That means mozilla::net::nsHttpConnectionMgr::Init() [2] haven't been called yet. And, it's called by nsHttpHandler::InitConnectionMgr() [3], which is called by nsHttpHandler::Init() [4].

Meanwhile, nsHttpHandler::Init() also initialize the mIOService [5] and we use its member function to NewURI() to convert URI from nsString to nsIURI. Thus, NS_NewURI() fails.

[1] http://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpConnectionMgr.cpp#291-294
[2] http://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpConnectionMgr.cpp#171-202
[3] http://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpHandler.cpp#593
[4] http://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpHandler.cpp#484
[5] http://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpHandler.cpp#412

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Maybe Shian-Yow could point us certain necko folks who could check what comment 2 found.

Comment 4

[Shian-Yow Wu [:swu]]

Kershaw, do you have idea about what found in comment 2?

Comment 5

[Kershaw Chang [:kershaw]]

(In reply to Tom Tung [:tt] from comment #2)
> It seems like we cannot get IOService while wanting to convert the URI from
> nsString to nsIURI.
> 
> From the log just before hitting the assert in attachment 8913558 [details]:
> 
> [Parent 15883, Main Thread] WARNING: cannot post event if not initialized:
> file
> /builds/worker/workspace/build/src/netwerk/protocol/http/nsHttpConnectionMgr.
> cpp, line 292
> 
> It shows that mSocketThreadTarget [1] hasn't been set at this time. That
> means mozilla::net::nsHttpConnectionMgr::Init() [2] haven't been called yet.
> And, it's called by nsHttpHandler::InitConnectionMgr() [3], which is called
> by nsHttpHandler::Init() [4].
> 

When mSocketThreadTarget is null, it could also be happened during shutdown.
I think maybe we should remove the asseration at [1] since NS_NewURI could be failed during shutdown.

What do you think, Tom?

[1] https://searchfox.org/mozilla-central/rev/31606bbabc50b08895d843b9f5f3da938ccdfbbf/dom/console/ConsoleReportCollector.cpp#80

Comment 6

[Tom Tung [:tt, :ttung]]

I'm fine with removing it. Thanks!

Just want to note that if we remove this line, the error reports won't show up to web/browser console. Also, we need to add NS_WARN_IF() to this line [1].

[1] https://searchfox.org/mozilla-central/rev/31606bbabc50b08895d843b9f5f3da938ccdfbbf/dom/console/ConsoleReportCollector.cpp#81

Comment 7

[Intermittent Failures Robot]

1 failures in 2981 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1404207&startday=2019-02-25&endday=2019-03-03&tree=all

Comment 8

[Intermittent Failures Robot]

1 failures in 4472 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1404207&startday=2020-01-06&endday=2020-01-12&tree=all

Comment 9

[Intermittent Failures Robot]

1 failures in 4823 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux1804-64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1404207&startday=2020-04-06&endday=2020-04-12&tree=all

Comment 10

[Bob Clary [:bc] (inactive)]

No longer asserts on Linux debug or asan debug. Maybe fixed by bug 1628728 but resolving WFM.