1404246 - [Windows] Disabled overflow scroll buttons are too dark

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Johann Hofmann [:johannh]]

We made a fix for Windows 7 in bug 1403110, but this affects all Windows versions.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1404246 - Fix disabled scroll buttons in the tabs toolbar on Windows properly.

Review commit: https://reviewboard.mozilla.org/r/184990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184990/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8913608 [details]
Bug 1404246 - Fix disabled scroll buttons in the tabs toolbar on Windows properly.

https://reviewboard.mozilla.org/r/184990/#review190076

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24771058db08
Fix disabled scroll buttons in the tabs toolbar on Windows properly. r=dao

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/24771058db08

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8913608 [details]
Bug 1404246 - Fix disabled scroll buttons in the tabs toolbar on Windows properly.

Approval Request Comment
[Feature/Bug causing the regression]: Photon redesign/bug 1403110
[User impact if declined]: Overflow buttons on Windows 7 are hard to see in disabled state.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: Not really, it's easy to see when having tab overflow and scrolling to either end of the tab list.
[List of other uplifts needed for the feature/fix]: We need the patch in bug 1403110 to apply cleanly, see https://bugzilla.mozilla.org/show_bug.cgi?id=1403110#c8 for the approval request.
[Is the change risky?]: No
[Why is the change risky/not risky?]: Simple CSS change
[String changes made/needed]: None

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8913608 [details]
Bug 1404246 - Fix disabled scroll buttons in the tabs toolbar on Windows properly.

Photon related, beta57+

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f4474cbb84b4

Comment 8

[Valentina Claudia Ona]

I verify this issue using Latest Nightly 58.0a1 with build ID  20171017220415 but I can't see differences between older and latest build. Can you take screenshot to be more clear?

Comment 9

[Valentina Claudia Ona]

I retested this issue Latest Nightly 58.0a1 and Latest Firefox Beta 57.0b9 with build ID  20171017220415 and I can confirm the fix on Windows 10 x64. During the verification, I found out another issue, the arrow disabled overflow scroll buttons are too white and I logged a new bug 1409990 for this issue.