Reduce margin between the address bar and the menu button in popup windows

RESOLVED FIXED in Firefox 57

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 58
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 fixed, firefox58 fixed)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Followup from bug 1403853
(Assignee)

Updated

2 years ago
Flags: qe-verify-

Comment 2

2 years ago
mozreview-review
Comment on attachment 8913587 [details]
Bug 1404248 - Remove excess space between the address bar and the menu button in popups.

https://reviewboard.mozilla.org/r/184964/#review190122
Attachment #8913587 - Flags: review?(nhnt11) → review+

Comment 3

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4cae180f29c
Remove excess space between the address bar and the menu button in popups. r=nhnt11

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d4cae180f29c
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
(Assignee)

Comment 5

2 years ago
Comment on attachment 8913587 [details]
Bug 1404248 - Remove excess space between the address bar and the menu button in popups.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1015163
[User impact if declined]: no big impact, this is just polish
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: bug 1403853 should be uplifted first or along with this
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial CSS fix
[String changes made/needed]: /
Attachment #8913587 - Flags: approval-mozilla-beta?
status-firefox57: --- → affected
Comment on attachment 8913587 [details]
Bug 1404248 - Remove excess space between the address bar and the menu button in popups.

Polish photon, taking it.
Should be in 57b5
Attachment #8913587 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 7

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/03e6331a76b5
status-firefox57: affected → fixed
You need to log in before you can comment on or make changes to this bug.