1404263 - "View Bookmarks Toolbar" in Bookmarking Tools doesn't work correctly if the bookmarks toolbar was opened through other means

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Johann Hofmann [:johannh]]

STR:

- Right click the nav-bar and select "Bookmarks Toolbar" to show the bookmarks toolbar (or open the bookmarks toolbar through customize mode).
- Go to Library -> Bookmarks -> Bookmarking Tools
- Notice that the label says "View Bookmarks Toolbar" instead of "Hide"
- To make things worse, clicking the button will _hide_ the bookmarks toolbar (and the button will permanently stay in opposite-mode until you manipulate the bookmarks toolbar through other means again).

Comment 1

[Johann Hofmann [:johannh]]

(In reply to Johann Hofmann [:johannh] from comment #0)
> (and the button will permanently stay in opposite-mode until you
> manipulate the bookmarks toolbar through other means again).

Hmm, I can't reproduce this part anymore, though I'm sure it was happening earlier. Anyway, still a bug :D

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1404263 - update the bookmarks toolbar item in the bookmarking tools subview when it is shown,

Review commit: https://reviewboard.mozilla.org/r/186344/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186344/

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8915080 [details]
Bug 1404263 - update the bookmarks toolbar item in the bookmarking tools subview when it is shown,

https://reviewboard.mozilla.org/r/186344/#review191416

LGTM, thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d508870ea425
update the bookmarks toolbar item in the bookmarking tools subview when it is shown, r=mikedeboer

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d508870ea425

Comment 6

[:Gijs (he/him)]

Comment on attachment 8915080 [details]
Bug 1404263 - update the bookmarks toolbar item in the bookmarking tools subview when it is shown,

Approval Request Comment
[Feature/Bug causing the regression]: bug 1377968
[User impact if declined]: confusing entry in the bookmarking tools subview that doesn't match reality and/or doesn't do anything when clicked
[Is this code covered by automated tests?]: no :-(
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: yeeah.
Stress-test showing/hiding the menu from:
- the toplevel menu
- the context menu on the toolbar
- the dropdown button menu in customize mode
- the item in the bookmarking tools (library > bookmarks > bookmarking tools > view/hide bookmarking toolbar)

and check that the label always makes sense (says "hide" when the toolbar is visible and vice versa) and that clicking it always changes the toolbar's state.
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: not really
[Why is the change risky/not risky?]: it's a small frontend/js-only change in pretty-far-hidden UI (which I guess is why we didn't notice it was broken before now...) and the change is fairly straightforward. Plus we still have quite some betas left to go.
[String changes made/needed]: nope

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8915080 [details]
Bug 1404263 - update the bookmarks toolbar item in the bookmarking tools subview when it is shown,

Photon fit and finish, beta57+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5acadbb892b0

Comment 9

[Stefan [:StefanG_QA]]

Verified fixed using the Firefox Beta 57.0b7 on Windows 10 x64, Windows 7 x86, Ubuntu 16.04 x64 and Mac OS X 10.13

Comment 10

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 58 beta 3 under Win 10 64-bit and Mac OS X 10.13.