Closed Bug 1404263 Opened 2 years ago Closed 2 years ago
"View Bookmarks Toolbar" in Bookmarking Tools doesn't work correctly if the bookmarks toolbar was opened through other means
59 bytes, text/x-review-board-request
STR: - Right click the nav-bar and select "Bookmarks Toolbar" to show the bookmarks toolbar (or open the bookmarks toolbar through customize mode). - Go to Library -> Bookmarks -> Bookmarking Tools - Notice that the label says "View Bookmarks Toolbar" instead of "Hide" - To make things worse, clicking the button will _hide_ the bookmarks toolbar (and the button will permanently stay in opposite-mode until you manipulate the bookmarks toolbar through other means again).
(In reply to Johann Hofmann [:johannh] from comment #0) > (and the button will permanently stay in opposite-mode until you > manipulate the bookmarks toolbar through other means again). Hmm, I can't reproduce this part anymore, though I'm sure it was happening earlier. Anyway, still a bug :D
Priority: -- → P3
QA Contact: gwimberly
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment on attachment 8915080 [details] Bug 1404263 - update the bookmarks toolbar item in the bookmarking tools subview when it is shown, https://reviewboard.mozilla.org/r/186344/#review191416 LGTM, thanks!
Attachment #8915080 - Flags: review?(mdeboer) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/d508870ea425 update the bookmarks toolbar item in the bookmarking tools subview when it is shown, r=mikedeboer
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8915080 [details] Bug 1404263 - update the bookmarks toolbar item in the bookmarking tools subview when it is shown, Approval Request Comment [Feature/Bug causing the regression]: bug 1377968 [User impact if declined]: confusing entry in the bookmarking tools subview that doesn't match reality and/or doesn't do anything when clicked [Is this code covered by automated tests?]: no :-( [Has the fix been verified in Nightly?]: not yet [Needs manual test from QE? If yes, steps to reproduce]: yeeah. Stress-test showing/hiding the menu from: - the toplevel menu - the context menu on the toolbar - the dropdown button menu in customize mode - the item in the bookmarking tools (library > bookmarks > bookmarking tools > view/hide bookmarking toolbar) and check that the label always makes sense (says "hide" when the toolbar is visible and vice versa) and that clicking it always changes the toolbar's state. [List of other uplifts needed for the feature/fix]: n/a [Is the change risky?]: not really [Why is the change risky/not risky?]: it's a small frontend/js-only change in pretty-far-hidden UI (which I guess is why we didn't notice it was broken before now...) and the change is fairly straightforward. Plus we still have quite some betas left to go. [String changes made/needed]: nope
Attachment #8915080 - Flags: approval-mozilla-beta?
Comment on attachment 8915080 [details] Bug 1404263 - update the bookmarks toolbar item in the bookmarking tools subview when it is shown, Photon fit and finish, beta57+
Attachment #8915080 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified fixed using the Firefox Beta 57.0b7 on Windows 10 x64, Windows 7 x86, Ubuntu 16.04 x64 and Mac OS X 10.13
Verified as fixed using Firefox 58 beta 3 under Win 10 64-bit and Mac OS X 10.13.
You need to log in before you can comment on or make changes to this bug.