Closed Bug 1404268 Opened 2 years ago Closed 2 years ago

Windows 7 nav bar should not have a top border radius

Categories

(Firefox :: Theme, defect, P1)

57 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
firefox56 --- unaffected
firefox57 --- verified
firefox58 --- verified

People

(Reporter: johannh, Assigned: johannh)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(1 file)

Comment on attachment 8913598 [details]
Bug 1404268 - Remove top border-radius from the Windows 7 glass nav bar.

https://reviewboard.mozilla.org/r/184986/#review190068
Attachment #8913598 - Flags: review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/858d90b340c2
Remove top border-radius from the Windows 7 glass nav bar. r=dao
Attachment #8913598 - Flags: review?(nhnt11)
https://hg.mozilla.org/mozilla-central/rev/858d90b340c2
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
QA Contact: ovidiu.boca
Comment on attachment 8913598 [details]
Bug 1404268 - Remove top border-radius from the Windows 7 glass nav bar.

Approval Request Comment
[Feature/Bug causing the regression]: Photon polish
[User impact if declined]: Slightly inconsistent border edges on Windows 7 (can look ugly if there's no drag space in front of tabs)
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Removes a CSS border-radius from an element
[String changes made/needed]: None
Attachment #8913598 - Flags: approval-mozilla-beta?
I want to verify this and just to be sure that I’m looking at the right thing, please tell me what do you mean by top border-radius? Can you please attach a screenshot to be more clear? Thanks
Flags: needinfo?(jhofmann)
Comment on attachment 8913598 [details]
Bug 1404268 - Remove top border-radius from the Windows 7 glass nav bar.

Photon polish, Beta57+
Attachment #8913598 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Valentina Claudia Ona from comment #6)
> I want to verify this and just to be sure that I’m looking at the right
> thing, please tell me what do you mean by top border-radius? Can you please
> attach a screenshot to be more clear? Thanks

I don't think this bug needs special verification, it's easy to see it fixed on Beta and Nightly. If you know what to look for, admittedly. border-radius is what we call the rounded corners of boxes, you can try it on http://border-radius.com/

Thanks!
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(jhofmann)
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.