Closed Bug 1404368 Opened 2 years ago Closed 2 years ago

Enable browser_webconsole_document_focus.js in new frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

In http://searchfox.org/mozilla-central/source/devtools/client/webconsole/test/browser_webconsole_bug_588342_document_focus.js#16-22 , we tested that jsterm had the focused, and when closing the console that the focus was restored to the content document.
We should add the latter case in the new frontend test.
Priority: -- → P3
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
After thinking about it, it make sense to keep the old test and migrate it.
browser_webconsole_input_focus should be only about the input focus.
Summary: Add test case to devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_input_focus.js → Enable browser_webconsole_document_focus.js in new frontend
Comment on attachment 8939782 [details]
Bug 1404368 - Enable browser_webconsole_document_focus.js in new frontend;.

https://reviewboard.mozilla.org/r/210102/#review215842

Looks good, thanks!
Attachment #8939782 - Flags: review?(jdescottes) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a3eb4701aba
Enable browser_webconsole_document_focus.js in new frontend;r=jdescottes.
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/39a358d36267
Enable browser_webconsole_document_focus.js in new frontend;r=jdescottes.
https://hg.mozilla.org/mozilla-central/rev/39a358d36267
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Too late for 58, won't fix for 58.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.