Closed
Bug 1404368
Opened 7 years ago
Closed 6 years ago
Enable browser_webconsole_document_focus.js in new frontend
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)
RESOLVED
FIXED
Firefox 59
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Whiteboard: [newconsole-mvp])
Attachments
(1 file)
In http://searchfox.org/mozilla-central/source/devtools/client/webconsole/test/browser_webconsole_bug_588342_document_focus.js#16-22 , we tested that jsterm had the focused, and when closing the console that the focus was restored to the content document. We should add the latter case in the new frontend test.
Assignee | ||
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Priority: -- → P3
Updated•6 years ago
|
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee | ||
Comment 1•6 years ago
|
||
After thinking about it, it make sense to keep the old test and migrate it. browser_webconsole_input_focus should be only about the input focus.
Summary: Add test case to devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_input_focus.js → Enable browser_webconsole_document_focus.js in new frontend
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8939782 [details] Bug 1404368 - Enable browser_webconsole_document_focus.js in new frontend;. https://reviewboard.mozilla.org/r/210102/#review215842 Looks good, thanks!
Attachment #8939782 -
Flags: review?(jdescottes) → review+
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a3eb4701aba Enable browser_webconsole_document_focus.js in new frontend;r=jdescottes.
Updated•6 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Pushed by apavel@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/39a358d36267 Enable browser_webconsole_document_focus.js in new frontend;r=jdescottes.
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/39a358d36267
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8a3eb4701aba
Comment 8•6 years ago
|
||
Too late for 58, won't fix for 58.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•