Closed
Bug 1404378
Opened 7 years ago
Closed 6 years ago
Migrate browser_webconsole_bug_593003_iframe_wrong_hud.js to the new frontend
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)
RESOLVED
FIXED
Firefox 59
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Whiteboard: [newconsole-mvp])
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Priority: -- → P3
Updated•7 years ago
|
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8943149 [details] Bug 1404378 - Enable browser_webconsole_iframe_wrong_hud.js in new console frontend; . https://reviewboard.mozilla.org/r/213450/#review219206 Thanks! No issues. just some comments. This test clearly comes from the pre-toolbox era, hard to tell if it's worth keeping, but it doesn't hurt and works fine! ::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_iframe_wrong_hud.js:34 (Diff revision 1) > + > + info("Waiting for messages"); > + await waitFor(() => findMessage(hud1, TEST_IFRAME_URI, ".message.network")); > > - info("Checking for messages"); > - yield checkMessages(tab1, tab2); > + const hud2 = await openConsole(tab2); > + isnot(hud1.ui.outputNode, hud2.ui.outputNode, "the two outputNodes are different"); I feel like this test was only relevant before the toolbox was introduced. I think we can remove it. ::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_iframe_wrong_hud.js:40 (Diff revision 1) > -function* reloadTab(tab) { > +function reloadTab(tab) { > let loaded = BrowserTestUtils.browserLoaded(tab.linkedBrowser); > tab.linkedBrowser.reload(); > - yield loaded; > + return loaded; We could almost use refreshTab from shared-head.js. Sadly it doesn't work here because it uses the selectedBrowser rather than the linkedBrowser to do the refresh.
Attachment #8943149 -
Flags: review?(jdescottes) → review+
Comment hidden (mozreview-request) |
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7aef6a844efc Enable browser_webconsole_iframe_wrong_hud.js in new console frontend; r=jdescottes.
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7aef6a844efc
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•6 years ago
|
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•