1404378 - Migrate browser_webconsole_bug_593003_iframe_wrong_hud.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1404378 - Enable browser_webconsole_iframe_wrong_hud.js in new console frontend; .

Review commit: https://reviewboard.mozilla.org/r/213450/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213450/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8943149 [details]
Bug 1404378 - Enable browser_webconsole_iframe_wrong_hud.js in new console frontend; .

https://reviewboard.mozilla.org/r/213450/#review219206

Thanks! No issues. just some comments. 
This test clearly comes from the pre-toolbox era, hard to tell if it's worth keeping, but it doesn't hurt and works fine!

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_iframe_wrong_hud.js:34
(Diff revision 1)
> +
> +  info("Waiting for messages");
> +  await waitFor(() => findMessage(hud1, TEST_IFRAME_URI, ".message.network"));
>  
> -  info("Checking for messages");
> -  yield checkMessages(tab1, tab2);
> +  const hud2 = await openConsole(tab2);
> +  isnot(hud1.ui.outputNode, hud2.ui.outputNode, "the two outputNodes are different");

I feel like this test was only relevant before the toolbox was introduced. I think we can remove it.

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_iframe_wrong_hud.js:40
(Diff revision 1)
> -function* reloadTab(tab) {
> +function reloadTab(tab) {
>    let loaded = BrowserTestUtils.browserLoaded(tab.linkedBrowser);
>    tab.linkedBrowser.reload();
> -  yield loaded;
> +  return loaded;

We could almost use refreshTab from shared-head.js. Sadly it doesn't work here because it uses the selectedBrowser rather than the linkedBrowser to do the refresh.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8943149 [details]
Bug 1404378 - Enable browser_webconsole_iframe_wrong_hud.js in new console frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213450/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7aef6a844efc
Enable browser_webconsole_iframe_wrong_hud.js in new console frontend; r=jdescottes.

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7aef6a844efc