1404392 - Add a test to make sure filtering don't alter scroll position

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

A test case could be added in new-console-output/test/mochitest/browser_webconsole_scroll.js to make sure disabling a filter does not alter scroll position, like http://searchfox.org/mozilla-central/source/devtools/client/webconsole/test/browser_webconsole_bug_597460_filter_scroll.js does in the old console

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1404392 - Enable and refactor browser_webconsole_filter_scroll.js to check that filtering does not affect scroll position; .

Review commit: https://reviewboard.mozilla.org/r/211042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211042/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8940771 [details]
Bug 1404392 - Enable and refactor browser_webconsole_filter_scroll.js to check that filtering does not affect scroll position; .

https://reviewboard.mozilla.org/r/211042/#review216782

Nice refactoring!

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8940771 [details]
Bug 1404392 - Enable and refactor browser_webconsole_filter_scroll.js to check that filtering does not affect scroll position; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211042/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6575fa09e55f
Enable and refactor browser_webconsole_filter_scroll.js to check that filtering does not affect scroll position; r=bgrins.

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6575fa09e55f