Closed Bug 1404392 Opened 2 years ago Closed 2 years ago

Add a test to make sure filtering don't alter scroll position

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox57 wontfix, firefox58 fix-optional, firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox57 --- wontfix
firefox58 --- fix-optional
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

A test case could be added in new-console-output/test/mochitest/browser_webconsole_scroll.js to make sure disabling a filter does not alter scroll position, like http://searchfox.org/mozilla-central/source/devtools/client/webconsole/test/browser_webconsole_bug_597460_filter_scroll.js does in the old console
Summary: Add a test tp make sure filtering don't alter scroll position → Add a test to make sure filtering don't alter scroll position
Priority: -- → P3
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8940771 [details]
Bug 1404392 - Enable and refactor browser_webconsole_filter_scroll.js to check that filtering does not affect scroll position; .

https://reviewboard.mozilla.org/r/211042/#review216782

Nice refactoring!
Attachment #8940771 - Flags: review?(bgrinstead) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6575fa09e55f
Enable and refactor browser_webconsole_filter_scroll.js to check that filtering does not affect scroll position; r=bgrins.
https://hg.mozilla.org/mozilla-central/rev/6575fa09e55f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.