Closed Bug 1404400 Opened 2 years ago Closed 2 years ago

Remove browser_webconsole_bug_600183_charset.js in the new frontend

Categories

(DevTools :: Console, enhancement, P3)

Product:
DevTools
Component:
Console
Type:
enhancement

Tracking

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1404400 - Delete browser_webconsole_charset.js from new frontend;.
59 bytes, text/x-review-board-request
Honza
: review+
Details 
No description provided.
status-firefox57: --- → wontfix
Priority: -- → P3
The test was originally testing the webconsole HTTPinspector. But this is done by calling a webconsole client method that is now only called from test (getResponseContent : https://searchfox.org/mozilla-central/search?q=getResponseContent&case=false&regexp=false&path=devtools%2F).
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Summary: Migrate browser_webconsole_bug_600183_charset.js to the new frontend → Remove browser_webconsole_bug_600183_charset.js in the new frontend
Comment on attachment 8928438 [details]
Bug 1404400 - Delete browser_webconsole_charset.js from new frontend;.

https://reviewboard.mozilla.org/r/199686/#review205428

I like removing code!

R+

Honza
Attachment #8928438 - Flags: review?(odvarko) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c30145251a4
Delete browser_webconsole_charset.js from new frontend;r=Honza.
https://hg.mozilla.org/mozilla-central/rev/1c30145251a4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Mass won't fix for 58. Let it ride the train.
status-firefox58: affected → wontfix
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.