1404401 - Taskgraph python tests fail on try when using 'try_task_config.json'

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Andrew Halberstadt [:ahal]]

E.g:
https://treeherder.mozilla.org/logviewer.html#?job_id=134049454&repo=try&lineNumber=276

This seems to happen because the decision task parameters have 'try_mode' and 'try_task_config' set. These failures are safe to ignore as they won't fail on the integration branches, but they still cause confusion.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I left this for a while, but looking now.. I'm pretty confused.  The tests do not take the current branch into account.  Why would they fail on try but not on my laptop and not in integration branches?

Comment 2

[Andrew Halberstadt [:ahal]]

Oh, because try_task_config.json exists:
http://searchfox.org/mozilla-central/source/taskcluster/taskgraph/decision.py#203

There are three tests that call that decision.get_decision_parameters().

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1404401 - ignore presence of target_task_config.json in tests;

I *think* the modifications to MockedOpen are correct, but I'm not sure..

Review commit: https://reviewboard.mozilla.org/r/188836/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188836/

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8917938 [details]
Bug 1404401 - ignore presence of target_task_config.json in tests;

https://reviewboard.mozilla.org/r/188836/#review194200

I'm not really familiar with this class either, but I think this looks good. Either way it's probably safe to land, anything it breaks should cause a backout.

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 3b4bda79d6a9 -d ff0c7c7b1074: rebasing 426224:3b4bda79d6a9 "Bug 1404401 - ignore presence of target_task_config.json in tests; r=ahal" (tip)
merging taskcluster/taskgraph/test/test_decision.py
warning: conflicts while merging taskcluster/taskgraph/test/test_decision.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8917938 [details]
Bug 1404401 - ignore presence of target_task_config.json in tests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188836/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e80ad94e2a5
ignore presence of target_task_config.json in tests; r=ahal

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5e80ad94e2a5