DOMi can't inspect anymore

RESOLVED FIXED in mozilla59

Status

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Paenglab, Assigned: frg)

Tracking

Trunk
mozilla59
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.54 fixed, seamonkey2.55 fixed, seamonkey2.56 fixed)

Details

Attachments

(1 attachment)

The errors I get:
this.mShell is null  Flasher.js:210
TypeError: this.mShell is null[Learn More]  Flasher.js:172:3
TypeError: this.mTransactionManager is null[Learn More]  inspector.xml:288:11
I borrowed the fix for the flasher from DOM Inspector Plus (big thanks) and fixed the pref calls for 58+. setStringPref and setStringPref were added in 54 so I opted for 55+ in the code. Bug 1414096 for Gecko 58 removed support for nsISupportsString values in nsPrefBranch::{get,set}ComplexValue().

This needs bug 1414398 fixed and ported to work. DOMi uses its own default preferences. Moving them into the scripts should be done in a separate bug. Because of this DOMi will no longer work in Firefox post 57.

Because of the error the code ran into the LegacyFlasher constuctor which confused me first. Per Bug 368608 it should never do for Gecko 25.0a2 and up so I put a version check instead of the try in.

Let me know if the whitespace changes can stay.
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attachment #8934270 - Flags: review?(iann_bugzilla)
Depends on: 1414398
Two remarks: {get|set}StringPref were introduced in bug 1345294 in mozilla55 (not 54). So you must use 55+.

TB 58 beta has the "defaults/preferences" problem fixed via a branch and backout on M-B, so the DOM Inspector works fine there with the patch here applied.
Comment on attachment 8934270 [details] [diff] [review]
1404423-DOMiPost56.patch

r=me with comment addressed
Attachment #8934270 - Flags: review?(iann_bugzilla) → review+
Which comment?
> Which comment?

Probably yours wrt 54. But the patch uses 55.0a1 for checking so it is ok.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.