Closed Bug 1404478 Opened 3 years ago Closed 3 years ago

Send actual CPU architecture in core ping

Categories

(Firefox for Android :: Metrics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 --- fixed
firefox58 --- fixed

People

(Reporter: snorp, Assigned: snorp)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1357786 +++

This is still broken. We're sending Build.CPU_ABI now instead of AppConstants.ANDROID_CPU_ARCH, but the Build.CPU_ABI is always a 32-bit ABI because we're in a 32-bit process. We need to send Build.SUPPORTED_ABIS[0] to get the most-preferred ABI for the device.
Assignee: nobody → snorp
Comment on attachment 8913829 [details]
Bug 1404478 - For reals send the right CPU ABI in the core ping

https://reviewboard.mozilla.org/r/185202/#review190660

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/HardwareUtils.java:82
(Diff revision 2)
>  
>      public static int getMemSize() {
>          return SysInfo.getMemSize();
>      }
>  
> -    private static String getPreferredAbi() {
> +    public static String getPreferredAbi() {

Don't need this now.
Attachment #8913829 - Flags: review?(nchen) → review+
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4f4e93e7057
For reals send the right CPU ABI in the core ping r=jchen
Comment on attachment 8913829 [details]
Bug 1404478 - For reals send the right CPU ABI in the core ping

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1357786, but was broken before too
[User impact if declined]: None, but we get bad telemetry data
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: We're simply sending a different value in Telemetry, using an existing API.
[String changes made/needed]: None

If we can get this in 57 it will allow us to more quickly see how many of our users are on 64 bit devices.
Attachment #8913829 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/b4f4e93e7057
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8913829 [details]
Bug 1404478 - For reals send the right CPU ABI in the core ping

Very low risk uplift, Beta57+
Attachment #8913829 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.