1404496 - Window specific themes should not reset when previewing a theme in customize mode

Status: NEW

(Firefox :: Theme, defect, P3)

Description

[fx4waldi]

Attachment: bug theme API.xpi

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20170929100122

Steps to reproduce:

1. Install an extension from attachment
2 [review]. Open new private window
3. Open "Customization mode"
4. Hover over a theme eg. "Dark theme" (do not click)
5. Close "Customization mode"
6. Open next new window



Actual results:

1. The first window (without the red theme) has a theme that was pointed at the cursor.
2. Third window (and each next) has a red theme


Expected results:

1. Theme shouldn't change
2. Theme should be applied only to private windows

Comment 1

[:Gijs (he/him)]

Can you look into this, :ntim?

Comment 2

[Tim Nguyen :ntim]

This is on my list after bug 1404855

Comment 3

[Mike de Boer [:mikedeboer]]

The solution for this bug would be to pass in the outerWindowID to the preview method, and ultimately passed along to the LightWeightThemeConsumer class.
IOW: make the preview functionality scoped to the active window. That the preview feature will be cheaper to render is a nice side-effect.