1404520 - Add support for asan builds to mozregression

Status: RESOLVED FIXED

(Testing :: mozregression, enhancement)

Description

[Ryan VanderMeulen [:RyanVM]]

It would be helpful for tracking down some fuzz bugs if mozregression supported ASAN builds as well.

I *think* this should be as easy as teaching it how to search the TC index for the right builds when |-B asan| is specified and making sure the llvm-symbolizer path is set via https://developer.mozilla.org/en-US/docs/Mozilla/Testing/Firefox_and_Address_Sanitizer#Using_the_LLVM_Symbolizer_(recommended).

Comment 1

[Botond Ballo [:botond]]

What I find particularly confusing is that |mozregression --list-build-types| lists "asan" as a possible build type, but when I actually try to use |--build-type asan| I get an error:

Traceback (most recent call last):
  File "/usr/local/bin/mozregression", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/mozregression/main.py", line 323, in main
    sys.exit(method())
  File "/usr/local/lib/python2.7/dist-packages/mozregression/main.py", line 271, in launch_nightlies
    self._launch(NightlyInfoFetcher)
  File "/usr/local/lib/python2.7/dist-packages/mozregression/main.py", line 266, in _launch
    build_info = fetcher.find_build_info(self.options.launch)
  File "/usr/local/lib/python2.7/dist-packages/mozregression/fetch_build_info.py", line 282, in find_build_info
    build_url=infos['build_url'],
KeyError: 'build_url'

Comment 2

[Māris Fogels [:mars] (please needinfo)]

Attachment: GitHub Pull Request

Comment 3

[Māris Fogels [:mars] (please needinfo)]

Attachment: GitHub Pull Request

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub master push: https://github.com/mozilla/mozregression/commit/b7ede1db40dad013e9d5591f215992de69d972ad

Commit merged into master by William Lachance (wlach)
Authored by Mars (mars-f)

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub master push: https://github.com/mozilla/mozregression/commit/cadcc2a4e4038994c8d9f9b94a842e76d805165d

Commit merged into master by William Lachance (wlach)
Authored by Mars (mars-f)

Comment 6

[William Lachance (:wlach)]

I merged the above PRs. I don't have time to test this right now, but am happy to take your word for this one. Mars, feel free to resolve this bug if you feel it's fixed.

Comment 7

[Māris Fogels [:mars] (please needinfo)]

The patches worked for me. Marking as fixed, but feel free to re-open if there are other problems working with ASAN builds.