1404534 - Move WebVR to separate D3D11Device

Status: RESOLVED FIXED

(Core :: WebVR, enhancement, P1)

Description

[:kip (Kearwood Gilbert)]

In order to prepare for moving VRManagerParent to its own process and thread, we will need a separate D3D11 device.

Bug 1400457 must land first to eliminate dependencies to classes that assume the D3D11Device will be the same one used by the compositor thread.

Comment 1

[:kip (Kearwood Gilbert)]

Attachment: Bug 1404534 - Create new D3D11Device for WebVR

- As we are creating a separate VR process in Bug 1362578,
  we will need our own D3D11Device.
- Eventually, we will be allowing the VR device runtimes to
  help select the appropriate adapter / device based on the
  physical connection.  This function will be updated at that
  time.

Review commit: https://reviewboard.mozilla.org/r/185282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185282/

Comment 2

[u279076]

Assuming this is wontfix for Firefox 57 since the dependency is as well.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8913881 [details]
Bug 1404534 - Create new D3D11Device for WebVR

https://reviewboard.mozilla.org/r/185282/#review205592

Comment 4

[Jeff Muizelaar [:jrmuizel]]

I will not be able to get to this review until after the 24th as I'm on PTO

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8913881 [details]
Bug 1404534 - Create new D3D11Device for WebVR

https://reviewboard.mozilla.org/r/185282/#review209502

::: gfx/thebes/DeviceManagerDx.cpp:991
(Diff revision 1)
>  
> +RefPtr<ID3D11Device>
> +DeviceManagerDx::GetVRDevice()
> +{
> +  MutexAutoLock lock(mDeviceLock);
> +  if(!mVRDevice) {

nit: space between if and (

Comment 6

[Daosheng Mu[:daoshengmu]]

I have contacted with :jrmuizel, and he recommends me to reassign the reviewer to :dvander.

Comment 7

[:kip (Kearwood Gilbert)]

Comment on attachment 8913881 [details]
Bug 1404534 - Create new D3D11Device for WebVR

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/185282/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aee9bf60d370
Create new D3D11Device for WebVR r=dvander,jgilbert

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/aee9bf60d370