Closed Bug 1404534 Opened 2 years ago Closed 2 years ago

Move WebVR to separate D3D11Device

Categories

(Core :: WebVR, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: kip, Assigned: kip)

References

Details

Attachments

(1 file)

In order to prepare for moving VRManagerParent to its own process and thread, we will need a separate D3D11 device.

Bug 1400457 must land first to eliminate dependencies to classes that assume the D3D11Device will be the same one used by the compositor thread.
Attachment #8913881 - Flags: review?(jgilbert)
Assuming this is wontfix for Firefox 57 since the dependency is as well.
Comment on attachment 8913881 [details]
Bug 1404534 - Create new D3D11Device for WebVR

https://reviewboard.mozilla.org/r/185282/#review205592
Attachment #8913881 - Flags: review?(jgilbert) → review+
Attachment #8913881 - Flags: review?(jmuizelaar)
I will not be able to get to this review until after the 24th as I'm on PTO
Blocks: 1392217
Attachment #8913881 - Flags: review?(jmuizelaar) → review?(dvander)
Comment on attachment 8913881 [details]
Bug 1404534 - Create new D3D11Device for WebVR

https://reviewboard.mozilla.org/r/185282/#review209502

::: gfx/thebes/DeviceManagerDx.cpp:991
(Diff revision 1)
>  
> +RefPtr<ID3D11Device>
> +DeviceManagerDx::GetVRDevice()
> +{
> +  MutexAutoLock lock(mDeviceLock);
> +  if(!mVRDevice) {

nit: space between if and (
Attachment #8913881 - Flags: review?(dvander) → review+
I have contacted with :jrmuizel, and he recommends me to reassign the reviewer to :dvander.
Pushed by kgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aee9bf60d370
Create new D3D11Device for WebVR r=dvander,jgilbert
https://hg.mozilla.org/mozilla-central/rev/aee9bf60d370
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.