Closed Bug 1404547 Opened 7 years ago Closed 5 years ago

[meta] Enable 'enum' UBSan check

Categories

(Core :: Sanitizers, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: arthur, Assigned: tsmith)

References

(Depends on 5 open bugs, Blocks 1 open bug)

Details

(Keywords: meta, Whiteboard: [tor])

Attachments

(1 file, 1 obsolete file)

There are only a few more -fsanitize=enum in Mozilla's automated tests on the gcc Linux build. (See the bugs this bug depends on.) Once those are all fixed, we should be able to add the flags `-fsanitize=enum -fno-sanitize-recover=enum` to the debug build (or maybe the ASAN) build so that any future UBSAN enum errors are caught before they land.
No longer depends on: 1402316
This isn't a bmo bug, moving it somewhere slightly more appropriate.
Product: bugzilla.mozilla.org → Core
Version: Production → unspecified
I ran an fsanitize=enum on a gcc build to see what errors are remaining. https://treeherder.mozilla.org/#/jobs?repo=try&revision=d464e6aade11&selectedJob=134174002 I used the following script to download the logs files and extract and enumerate the runtime errors: https://github.com/arthuredelstein/firefox-ubsan-errors The results are as follows: https://docs.google.com/spreadsheets/d/1yB5TR8TYBa8zNkNLo8UhsjjkzypVDCEtnNVAkE23yLo/edit?usp=sharing
Depends on: 1404570
Depends on: 1404572
Depends on: 1404169, 1404174
Summary: Add -fsanitize=enum to debug build → [meta] Add -fsanitize=enum to debug build
Depends on: 1405139
Depends on: 1405142
Depends on: 1405147
Depends on: 1405154
Depends on: 1405156
Running -fsanitize=enum on linux64-asan (clang) detected 5 more enum error locations that gcc didn't detect. :P
Keywords: meta
Depends on: 1619468
Assignee: nobody → twsmith
Depends on: 1619484

Things have changed a bit since this bug was initially opened. Instead of adding the check to debug builds we will enable it on the ASan + UBSan builds.

Component: General → Security
Summary: [meta] Add -fsanitize=enum to debug build → [meta] Enable 'enum' UBSan check

Oops wrong component.

Component: Security → Sanitizers
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
Attachment #9130596 - Attachment is obsolete: true
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a007d28149d Enable 'enum' UBSan check. r=froydnj,mccr8
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: