1404583 - [macOS] [Photon] The Location Bar is not focussed when you open the first Tab with CMD-T while Firefox is already running

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Mehmet]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3228.0 Safari/537.36

Steps to reproduce:

macOS 10.12.6
58.0a1 (2017-09-29) (64-Bit)

1.) Start Firefox
2.) Close all windows
3.) Press Cmd-T to open a New Tab


Actual results:

The Location Bar is not focussed. You need to click into the Location Bar, so that you can start typing. It works fine, when you open a further Tab with CMD-T.


Expected results:

It should be focussed when you open the first Tab with CMD-T so that you are able to type immediately.

If you need more information, please let me know.

Thanks.

Comment 1

[Mehmet]

This seems to be a regression. Works fine in latest Firefox 56.0 Stable.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

What's your homepage set to?
What does the tab load?

Comment 3

[Mehmet]

Attachment: screencast.mov

(In reply to Marco Bonardo [::mak] from comment #2)
> What's your homepage set to?
> What does the tab load?

Thanks for your feedback. Here are your requested answers:

What's your homepage set to? --> Nightly Startpage
What does the tab load? The New Tab Page

Here is a screencast.

CMD-T (new Tab) doesn't focus the Address Bar
CMD-N (new Window) focusses it.

Thanks!

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Mardak, any insight here?

Comment 5

[Ed Lee :Mardak]

57.0a1 Build ID 	20170921100141 focuses address bar on about:newtab of new window
58.0a1 Build ID 	20170922100051 doesn't focus address bar on about:newtab of new window

Most likely bug 1399454

Comment 6

[Dão Gottwald [:dao]]

Attachment: Bug 1404583 - Make openLinkIn not steal focus from the address bar when loading the New Tab page.

Review commit: https://reviewboard.mozilla.org/r/187972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187972/

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8916934 [details]
Bug 1404583 - Make openLinkIn not steal focus from the address bar when loading the New Tab page.

https://reviewboard.mozilla.org/r/187972/#review193550

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e1474612b64
Make openLinkIn not steal focus from the address bar when loading the New Tab page. r=florian

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b3c3e279588
Backed out changeset 4e1474612b64 for failing browser-chrome's browser/modules/test/browser/browser_BrowserUITelemetry_syncedtabs.js. r=backout

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing browser-chrome's browser/modules/test/browser/browser_BrowserUITelemetry_syncedtabs.js:

https://hg.mozilla.org/integration/autoland/rev/8b3c3e27958867ff0135adf75be4e8daf4a7d745

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4e1474612b6402a3cbc70f9e5fcc449d37be018c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=136205055&repo=autoland

[task 2017-10-11T13:11:32.041Z] 13:11:32     INFO - TEST-START | browser/modules/test/browser/browser_BrowserUITelemetry_syncedtabs.js
[task 2017-10-11T13:11:32.151Z] 13:11:32     INFO - GECKO(3236) | 1507727492145	addons.xpi	WARN	Attempting to activate an already active default theme
[task 2017-10-11T13:11:32.452Z] 13:11:32     INFO - GECKO(3236) | JavaScript error: chrome://browser/content/utilityOverlay.js, line 454: ReferenceError: gURLBar is not defined
[task 2017-10-11T13:11:32.457Z] 13:11:32     INFO - TEST-INFO | started process screentopng
[task 2017-10-11T13:11:34.005Z] 13:11:34     INFO - TEST-INFO | screentopng: exit 0
[task 2017-10-11T13:11:34.006Z] 13:11:34     INFO - Buffered messages logged at 13:11:32
[task 2017-10-11T13:11:34.006Z] 13:11:34     INFO - Entering test bound test_menu
[task 2017-10-11T13:11:34.008Z] 13:11:34     INFO - TEST-PASS | browser/modules/test/browser/browser_BrowserUITelemetry_syncedtabs.js | {"click-builtin-item":{"sync-button":{"left":1}},"synced-tabs":{"open":{"toolbarbutton-subview":1}}} deepEqual {"click-builtin-item":{"sync-button":{"left":1}},"synced-tabs":{"open":{"toolbarbutton-subview":1}}} - 
[task 2017-10-11T13:11:34.013Z] 13:11:34     INFO - Leaving test bound test_menu
[task 2017-10-11T13:11:34.015Z] 13:11:34     INFO - Entering test bound test_sidebar
[task 2017-10-11T13:11:34.017Z] 13:11:34     INFO - Console message: 1507727492145	addons.xpi	WARN	Attempting to activate an already active default theme
[task 2017-10-11T13:11:34.019Z] 13:11:34     INFO - Buffered messages finished
[task 2017-10-11T13:11:34.025Z] 13:11:34     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_BrowserUITelemetry_syncedtabs.js | {"sidebar":{"viewTabsSidebar":{"show":1}}} deepEqual {"sidebar":{"viewTabsSidebar":{"show":1}},"synced-tabs":{"open":{"sidebar":1}}} - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser/browser_BrowserUITelemetry_syncedtabs.js :: test_sidebar :: line 109
[task 2017-10-11T13:11:34.028Z] 13:11:34     INFO - Stack trace:
[task 2017-10-11T13:11:34.036Z] 13:11:34     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_BrowserUITelemetry_syncedtabs.js:test_sidebar:109
[task 2017-10-11T13:11:34.038Z] 13:11:34     INFO - Leaving test bound test_sidebar

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 8916934 [details]
Bug 1404583 - Make openLinkIn not steal focus from the address bar when loading the New Tab page.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187972/diff/1-2/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93fc50f247f6
Make openLinkIn not steal focus from the address bar when loading the New Tab page. r=florian

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/93fc50f247f6

Comment 14

[Dão Gottwald [:dao]]

Comment on attachment 8916934 [details]
Bug 1404583 - Make openLinkIn not steal focus from the address bar when loading the New Tab page.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1399454
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial fix
[String changes made/needed]: /

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8916934 [details]
Bug 1404583 - Make openLinkIn not steal focus from the address bar when loading the New Tab page.

Recent regression, Beta57+

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/81ae808baaf1

Comment 17

[Oana Botisan, Desktop QA]

I managed to reproduce the bug using Mac OS X 10.11 on am older version of Nightly (2017-09-30).
I retested everything using latest 58 Nightly and beta 57.0b9 on Mac OS X 10.11 and macOS 10.12 and the bug is not reproducing anymore. In a new tab the focus is on the Navigation bar.