1404587 - Crash in sse2_composite_over_n_8_8888

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ekanan Ketunuti]

This bug was filed from the Socorro interface and is 
report bp-0bdf0480-6538-4595-b432-c721c0170930.
=============================================================

STR:
1. Set gfx.content.azure.backends to direct2d1.1,cairo
2. Open https://www.facebook.com/pg/cnn/videos/?ref=page_internal (login is not needed)

With step 1, it doesn't crash with layers.omtp.enabled=false.

Comment 1

[Calixte Denizet (:calixte)]

There are 154 crashes in nightly 58 starting with buildid 20170929220356.
The signature is ranked #10 in nightly top-crashers for content process.
:bas, could you investigate please ?

Comment 2

[Bas Schouten (:bas.schouten)]

This crash is a known bug in cairo when using multithreading.. I'm confused, why are there a bunch of these? Cairo is not a supported configuration any more and hasn't been for quite a while as far as I know? i.e. the pref change listed above puts you into an unsupported configuration. I have a patch locally to fix this issue by fixing the underlying issue in cairo, having said that I'm more worried about people using cairo in general. Maybe we should just remove support for this?

Milan, Lee, does either of you guys know where these users are coming from?

Comment 3

[Bas Schouten (:bas.schouten)]

(Note that many of these users are also on DWrite, DWrite+Cairo is also an unsupported configuration, even without OMTP)

Comment 4

[Nicholas Nethercote [inactive]]

This is the #4 Windows topcrash in Nightly 20170929220356.

Comment 5

[Bas Schouten (:bas.schouten)]

Attachment: Prevent people from still using cairo

This would solve the problem and bring windows in sync with what we're supporting on other platforms nowadays. What do you think?

Comment 6

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1404587: Disable OMTP when using cairo as the content backend.

Review commit: https://reviewboard.mozilla.org/r/185460/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185460/

Comment 7

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8914136 [details]
Bug 1404587: Disable OMTP when using cairo as the content backend.

https://reviewboard.mozilla.org/r/185460/#review190350

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b00cd35474a0
Disable OMTP when using cairo as the content backend. r=mattwoodrow

Comment 9

[Ekanan Ketunuti]

(In reply to Bas Schouten (:bas.schouten) from comment #2)
> Milan, Lee, does either of you guys know where these users are coming from?

Looking into crash-stats, most of them (incl. me) are using Mactype (https://github.com/snowie2000/mactype). Mactype doesn't work well with skia that's why they disable skia.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b00cd35474a0

Comment 11

[Bas Schouten (:bas.schouten)]

(In reply to Ekanan Ketunuti from comment #9)
> (In reply to Bas Schouten (:bas.schouten) from comment #2)
> > Milan, Lee, does either of you guys know where these users are coming from?
> 
> Looking into crash-stats, most of them (incl. me) are using Mactype
> (https://github.com/snowie2000/mactype). Mactype doesn't work well with skia
> that's why they disable skia.

I sort of assume it just 'doesn't' work, rather than not well :-).

It's really unfortunate, but we're going to have to shut cairo off eventually either way. It may be better to do it sooner rather than later.