Closed Bug 1404587 Opened 2 years ago Closed 2 years ago

Crash in sse2_composite_over_n_8_8888

Categories

(Core :: Graphics, defect, critical)

x86
Windows 10
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 --- fixed

People

(Reporter: ananuti, Assigned: bas.schouten)

References

Details

(Keywords: crash, regression, topcrash)

Crash Data

Attachments

(2 files)

This bug was filed from the Socorro interface and is 
report bp-0bdf0480-6538-4595-b432-c721c0170930.
=============================================================

STR:
1. Set gfx.content.azure.backends to direct2d1.1,cairo
2. Open https://www.facebook.com/pg/cnn/videos/?ref=page_internal (login is not needed)

With step 1, it doesn't crash with layers.omtp.enabled=false.
There are 154 crashes in nightly 58 starting with buildid 20170929220356.
The signature is ranked #10 in nightly top-crashers for content process.
:bas, could you investigate please ?
This crash is a known bug in cairo when using multithreading.. I'm confused, why are there a bunch of these? Cairo is not a supported configuration any more and hasn't been for quite a while as far as I know? i.e. the pref change listed above puts you into an unsupported configuration. I have a patch locally to fix this issue by fixing the underlying issue in cairo, having said that I'm more worried about people using cairo in general. Maybe we should just remove support for this?

Milan, Lee, does either of you guys know where these users are coming from?
Flags: needinfo?(milan)
Flags: needinfo?(lsalzman)
Flags: needinfo?(bas)
(Note that many of these users are also on DWrite, DWrite+Cairo is also an unsupported configuration, even without OMTP)
This is the #4 Windows topcrash in Nightly 20170929220356.
This would solve the problem and bring windows in sync with what we're supporting on other platforms nowadays. What do you think?
Assignee: nobody → bas
Status: NEW → ASSIGNED
Attachment #8914134 - Flags: feedback?(jmuizelaar)
Attachment #8914134 - Attachment is patch: true
Comment on attachment 8914136 [details]
Bug 1404587: Disable OMTP when using cairo as the content backend.

https://reviewboard.mozilla.org/r/185460/#review190350
Attachment #8914136 - Flags: review?(matt.woodrow) → review+
Pushed by bschouten@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b00cd35474a0
Disable OMTP when using cairo as the content backend. r=mattwoodrow
(In reply to Bas Schouten (:bas.schouten) from comment #2)
> Milan, Lee, does either of you guys know where these users are coming from?

Looking into crash-stats, most of them (incl. me) are using Mactype (https://github.com/snowie2000/mactype). Mactype doesn't work well with skia that's why they disable skia.
https://hg.mozilla.org/mozilla-central/rev/b00cd35474a0
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Attachment #8914134 - Flags: feedback?(jmuizelaar) → feedback+
(In reply to Ekanan Ketunuti from comment #9)
> (In reply to Bas Schouten (:bas.schouten) from comment #2)
> > Milan, Lee, does either of you guys know where these users are coming from?
> 
> Looking into crash-stats, most of them (incl. me) are using Mactype
> (https://github.com/snowie2000/mactype). Mactype doesn't work well with skia
> that's why they disable skia.

I sort of assume it just 'doesn't' work, rather than not well :-).

It's really unfortunate, but we're going to have to shut cairo off eventually either way. It may be better to do it sooner rather than later.
Flags: needinfo?(milan)
Flags: needinfo?(lsalzman)
You need to log in before you can comment on or make changes to this bug.