140464 - Cookies expire at end of session if Date header is missing

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[Marc Loiselle]

Going to thig url
http://www.vcitysoftware.com:8081/examples/servlet/CookieExample?cookiename=test&cookievalue=value

should set a cookie that expires in 60 minutes.  It does not.  According to the
Cookie Manager, the cookie expires at the end of the session.

This is happening because the webserver (Tomcat 3.2.3) does not send a Date
header in the response.

An empty server_date is being passed to COOKIE_SetCookieStringFromHttp instead
of null due to a recent change in nsCookieHTTPNotify.cpp.

I will attach a patch that fixes the problem.

Comment 1

[Marc Loiselle]

Attachment: Patch that fixes the problem

Comment 2

[Marc Loiselle]

Forgot to mention the buildId.  It is 2002042403 - Win2K.  The problem happens
with 1.0RC as well.  The problem does not occur with 0.9.9.

Comment 3

[Stephen P. Morse]

Comment on attachment 81238 [details] [diff] [review]
Patch that fixes the problem

r=morse

Comment 4

[Darin Fisher]

Comment on attachment 81238 [details] [diff] [review]
Patch that fixes the problem

sr=darin

Comment 5

[Marc Loiselle]

Stephen, 

Can you check in my patch to the trunk?

How do I get my patch approved to go into the 1.0 branch?

Comment 6

[Tom Everingham]

Gagan, steve is on vacation, can you check this in?

Comment 7

[Gagan]

no can do this week (in dulles) try dougt

Comment 8

[Jaime Rodriguez, Jr.]

Before it can be checked in, it needs both a= and adt1.0.0+.

Peter - Any word from Nav triage oin whether this is needed for RC2 or not?

Comment 9

[Peter Trudelle]

Is this happening on any top sites, or with any popular servers?

Comment 10

[Marc Loiselle]

The patch just simply corrects a regression.  The patch has minimal risk.

Comment 11

[Peter Trudelle]

That's not what I asked.

Comment 12

[Marc Loiselle]

Peter, I don't know if it is happening on top sites.  I just know that it is a
bug and it needs to be fixed since it worked before.  The problem also occurs if
the Date field is after the Set-Cookie field in the header.  This is a very
simple fix.

Comment 13

[Peter Trudelle]

We have a fix, I just need to determine if it has high enough impact to require
taking the fix for beta.  So far, we are unaware of any impact to target users.

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 81238 [details] [diff] [review]
Patch that fixes the problem

a=asa (on behalf of drivers) for checkin to the 1.0 branch. We're tight on time
so please land this ASAP.

Comment 15

[Samir Gehani]

Nav triage team: nsbeta1+, adt2 rtm

Comment 16

[Marc Loiselle]

Why has the patch not been checked into the trunk or the 1.0 branch?  There are
approvals for both.

Comment 17

[Peter Trudelle]

no, it doesn't.  a= is outdated, and there is no ADT approval.

Comment 18

[Marc Loiselle]

I thought that the a= is not required for the trunk.  Also, I didn't know that
a's expired.  I am getting frustrated by the process.  Patch should have checked
in to the trunk on Apr 30.  I understand that the process for patching the
branch is more difficult but to delay the check in for the trunk seems odd.

Comment 19

[Peter Trudelle]

You're right that a= is needed only on the branch, but nobody is purposely
delaying checkin to the trunk.  AFAIK, mozilla.org gives a= that is good for 3
days only.  I understand your frustration, but that is not my process, though I
do support it.  Steve Morse is on vacation until Monday, and my other engineers
are fully booked on work that is needed for our beta, but if you can get someone
else to check this in on the trunk for you, then go right ahead.

Comment 20

[Stephen P. Morse]

Checked in on trunk.

Comment 21

[Peter Trudelle]

fixed

Comment 22

[scottputterman]

adding adt1.0.0+.  Please get drivers approval since it's been more than 3 days
and then check into the 1.0 branch.

Comment 23

[Stephen P. Morse]

valeski just reapproved for drivers.  checked in on branch.

Comment 24

[Tom Everingham]

verified trunk and branch, 05/28/02 builds winNT4, linux rh6, mac osX