1404700 - Xmarks sync add-on doesn't work after update to Firefox 56.0 release (regression)

Status: RESOLVED WONTFIX

(WebExtensions :: General, defect)

Description

[nivtwig]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170926190823

Steps to reproduce:

Updated to Firefox 56.0 release.
Selected  Tools -> Xmarks -> Xmarks Settings... menu option

Note: The browser works in single process mode (not e10s) since xmarks is not multiprocess compatible. This is the same behavior as Firefox 55 and should be ok.



Actual results:

The Xmarks settings dialog is broken and unusable.

It is opened without showing any value in the "Current Status" and "Last Sync" fields, where it displayed values previously.

Clicking "Log out" and "Cancel" buttons doesn't do anything, it is just ignored .

Clicking "Synchronize Now" opens the dialog for synchronization and appears to synchronize at first, but actually just works forever, and you can't cancel the operation or dialog because clicking on the "Cancel" button is ignored. (clicking the X close window button works ok)



Expected results:

The issues listed above should work ...

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Have you reached out to the add-on developer? This is not an add-on developed by Mozilla. If xmarks-sync is the add-on you have, then the first review comment in the AMO page suggests that you might need to upgrade to their beta version:

https://addons.mozilla.org/en-US/firefox/addon/xmarks-sync/

Comment 2

[nivtwig]

I know it is not developed by Mozilla, I didn't contact the developers, but usually in the past, updating Firefox versions didn't break this add-on. 

Therefore, it seems that there was a change in Firefox 56 that broke the add-on compatibility (since the add-on version didn't change).
If there was an intentional change in Firefox that broke add-ons compatibility, shouldn't it at least be noted in the release notes ?
And if it wasn't intentional, then there is a chance it can still be a Firefox bug.

Anyway, I will try the add-on beta .

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Every Firefox release has the potential to impact add-on compatibility, and we post regular updates in the Add-ons Blog about this (https://blog.mozilla.org/addons/).

Starting with Firefox 57, things will improve significantly, but add-ons need to be ported to use the WebExtensions API in order to use this new system. Xmarks Sync hasn't ported yet but it looks like the beta versions are now using WebExtensions.

I don't think there's anything for us to do here.