1404754 - HTML in theme descriptions is displayed raw in Addons Manager

Status: RESOLVED DUPLICATE of bug 679633

(Toolkit :: Add-ons Manager, defect)

Description

[bvanoudtshoorn]

Attachment: Themes summary view

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170925150345

Steps to reproduce:

Install a theme which includes basic HTML (as allowed by AMO) in its description; for example, https://addons.mozilla.org/en-US/firefox/addon/colours-in-bokeh/.

Then load the Addons Manager and navigate to themes.


Actual results:

The HTML is displayed "raw" (that is, as the string itself) in both the summary view and in the details view for the theme. See the attached screenshots.


Expected results:

The HTML should either be displayed as expected, or it should be stripped so that only the text content is displayed.

Comment 1

[bvanoudtshoorn]

Attachment: Details view

Comment 3

[bvanoudtshoorn]

I think that 679633 may be invalid now, as comments in there note that the addons manager _strips_ HTML -- which isn't happening any more. Whilst accepting HTML (as per 679633) would resolve the issue outlined here, I think that simply restoring HTML stripping would _also_ resolve this one -- and probably be a bit simpler and safer to implement. (Although I, of course, have no idea how complex that is within this context!)

Comment 4

[Andrew Swan [:aswan]]

Sorry for the delayed response, but this is about lightweight themes, which are in the process of being replaced with a new format with packaging based on webextensions.  In the mean time, stripping HTML from the description would have to happen on AMO, you can file an AMO bug at https://github.com/mozilla/addons about that if you like...