1404782 - Do not mutate display list in the layers-free mode

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Ethan Lin[:ethlin]]

Currently we remove/insert display items from/to the display list when we create WR commands. It may change the original display list and it sometimes makes the retain display list not working.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Bug 1404782 - Do not mutate display list in layers-free mode.

Review commit: https://reviewboard.mozilla.org/r/185564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185564/

Comment 2

[Ethan Lin[:ethlin]]

Attachment: Bug 1404782 - Update reftest annotation after the fix.

Review commit: https://reviewboard.mozilla.org/r/185574/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185574/

Comment 3

[Ethan Lin[:ethlin]]

There is a unexpected-pass test[1], so I remove the fails-if(webrender) for the testcase. 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0402bf55e4ff3d8b567cc470c37fb2f13988a90e&selectedJob=134351327

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8914243 [details]
Bug 1404782 - Do not mutate display list in layers-free mode.

https://reviewboard.mozilla.org/r/185564/#review190758

Comment 5

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8914256 [details]
Bug 1404782 - Update reftest annotation after the fix.

https://reviewboard.mozilla.org/r/185574/#review190760

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db40593b664c
Do not mutate display list in layers-free mode. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/6869bf44878d
Update reftest annotation after the fix. r=mattwoodrow

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/db40593b664c
https://hg.mozilla.org/mozilla-central/rev/6869bf44878d