Closed Bug 1404796 Opened 2 years ago Closed 2 years ago

On mac, the app name is "FirefoxNightly" when it should be "Firefox Nightly"

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox58 wontfix, firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

I thought the build system would use the other package names but it isn't.

For now, if MOZ_APP_DISPLAYNAME = "Firefox Nightly", the build will fail with:
05:34:57    ERROR -  mozinstall.mozinstall.InstallError: Failed to install "/Users/cltbld/tasks/task_1505306020/installer.dmg ([Errno 2] No such file or directory: '/Volumes/Firefox')"
Because we are doing some parsing of the output of the "hdiutil" command [1] and the output varies, we have to do some better parsing of the output.

[1] https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozinstall/mozinstall/mozinstall.py#281
Firefox Developer Edition also has the same bug.
Depends on: 1404480
Stephen, what do you think? I guess this will retrigger again the warning about the default browser.
Flags: needinfo?(spohl.mozilla.bugs)
Assignee: nobody → sledru
Yes, it will retrigger the bug. But if we want to change the name, it has to be "Firefox Nightly" with a space. What happens if you escape the space, i.e. MOZ_APP_DISPLAYNAME = "Firefox\ Nightly"
Flags: needinfo?(spohl.mozilla.bugs)
I think I fixed this issue in bug 1404480.
Blocks: 1404956
https://hg.mozilla.org/projects/oak/rev/e8f2721a1f1f588e7e12cb84d2c1542c9ef87985
Bug 1404796 - Add space in the Display name of Firefox {Nightly, Developer Edition}
Depends on: 1407285
Attachment #8914326 - Flags: review?(spohl.mozilla.bugs)
Attachment #8914326 - Flags: review?(spohl.mozilla.bugs) → review?(dtownsend)
Attachment #8914326 - Flags: review?(dtownsend) → review?(mh+mozilla)
Mossop told me that we need a build peer here.
Mike, this will land with bug 1378834, bug 1404823 and bug 1399457 at the same time.
Comment on attachment 8914326 [details]
Bug 1404796 - Add space in the Display name of Firefox {Nightly, Developer Edition}

https://reviewboard.mozilla.org/r/185610/#review212046
Attachment #8914326 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/42339ef2360cf8875c195b1b20e133eddf6ee499
Bug 1404796 - Add space in the Display name of Firefox {Nightly, Developer Edition} r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/d71acb742e1106fa204287ec3ac1d45aba806d70
Bug 1404796 - Add space in the Display name of Firefox {Nightly, Developer Edition} r=glandium
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/86268d3881a5
Add space in the Display name of Firefox {Nightly, Developer Edition} r=glandium
Depends on: 1426743
https://hg.mozilla.org/mozilla-central/rev/86268d3881a5
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Flags: needinfo?(sledru)
Depends on: 1435359
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.