Closed
Bug 1404816
Opened 7 years ago
Closed 7 years ago
Update cog wheel icon in urlbar/address bar for search settings
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 58
People
(Reporter: alberts, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [reserve-photon-visual])
Attachments
(2 files)
|
99.79 KB,
image/png
|
Details | |
|
59 bytes,
text/x-review-board-request
|
adw
:
review+
ritu
:
approval-mozilla-beta+
|
Details |
address-bar-cog-icon.png
There is a settings icon (cog wheel) in the address bar / url bar (is it also still called awesomebar!?) that seems left behind. The new Photon style cog wheel seems already be used on all other places. See screenshot attached.
|
Reporter | |
Updated•7 years ago
|
Blocks: photon-visual
|
||
Updated•7 years ago
|
Component: Address Bar → Theme
|
Assignee | |
Updated•7 years ago
|
Priority: -- → P4
Whiteboard: [reserve-photon-visual]
|
||
Updated•7 years ago
|
Flags: qe-verify?
|
|
Assignee | |
Updated•7 years ago
|
Flags: qe-verify? → qe-verify+
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: P4 → P1
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8915041 [details] Bug 1404816 - Get rid of gear.svg in favor of settings.svg. https://reviewboard.mozilla.org/r/186308/#review191556
Attachment #8915041 -
Flags: review?(adw) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e2f8f4f1fc3 Get rid of gear.svg in favor of settings.svg. r=adw
|
|
Assignee | |
Comment 4•7 years ago
|
||
Comment on attachment 8915041 [details] Bug 1404816 - Get rid of gear.svg in favor of settings.svg. Approval Request Comment [Feature/Bug causing the regression]: photon-visual polish [User impact if declined]: inconsistent gear icon in the urlbar autocomplete popup [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: not yet [Needs manual test from QE? If yes, steps to reproduce]: [List of other uplifts needed for the feature/fix]: / [Is the change risky?]: no [Why is the change risky/not risky?]: just removing one icon in favor of another that we already use elsewhere [String changes made/needed]: /
Attachment #8915041 -
Flags: approval-mozilla-beta?
status-firefox57:
--- → affected
status-firefox58:
--- → affected
Comment on attachment 8915041 [details] Bug 1404816 - Get rid of gear.svg in favor of settings.svg. Photon fit and finish, Beta57+
Attachment #8915041 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Comment 6•7 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-beta/rev/f644bfb71ba6
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2e2f8f4f1fc3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Verified fixed using the latest Nightly (2017-10-11) and Firefox Beta 57.0b7 on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.10.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•