Closed Bug 1404816 Opened 2 years ago Closed 2 years ago

Update cog wheel icon in urlbar/address bar for search settings

Categories

(Firefox :: Theme, defect, P1)

57 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: alberts, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(2 files)

There is a settings icon (cog wheel) in the address bar / url bar (is it also still called awesomebar!?) that seems left behind. The new Photon style cog wheel seems already be used on all other places. See screenshot attached.
Component: Address Bar → Theme
Priority: -- → P4
Whiteboard: [reserve-photon-visual]
Flags: qe-verify?
Flags: qe-verify? → qe-verify+
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: P4 → P1
Comment on attachment 8915041 [details]
Bug 1404816 - Get rid of gear.svg in favor of settings.svg.

https://reviewboard.mozilla.org/r/186308/#review191556
Attachment #8915041 - Flags: review?(adw) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e2f8f4f1fc3
Get rid of gear.svg in favor of settings.svg. r=adw
Comment on attachment 8915041 [details]
Bug 1404816 - Get rid of gear.svg in favor of settings.svg.

Approval Request Comment
[Feature/Bug causing the regression]: photon-visual polish
[User impact if declined]: inconsistent gear icon in the urlbar autocomplete popup
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: just removing one icon in favor of another that we already use elsewhere
[String changes made/needed]: /
Attachment #8915041 - Flags: approval-mozilla-beta?
Comment on attachment 8915041 [details]
Bug 1404816 - Get rid of gear.svg in favor of settings.svg.

Photon fit and finish, Beta57+
Attachment #8915041 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/mozilla-central/rev/2e2f8f4f1fc3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Verified fixed using the latest Nightly (2017-10-11) and Firefox Beta 57.0b7 on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.10.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.