1404823 - Name of app bundle changed to FirefoxFirefoxNightly.app

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[matthias koplenig [:metasieben]]

As a regression of bug 1378834 the app-bundle is currently called >FirefoxFirefoxNightly.app<.

I'm guessing because the >Firefox< prefix is already specified in mozconfig (--with-macbundlename-prefix=Firefox)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1404823 - Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary

Review commit: https://reviewboard.mozilla.org/r/185560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185560/

Comment 2

[Stephen A Pohl [:spohl]]

Comment on attachment 8914240 [details]
Bug 1404823 - Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary

https://reviewboard.mozilla.org/r/185560/#review190586

This seems like the right thing to do, but it needs a review from release engineering[1]. There is at least the whitelist[2] that might need to get changed as well.

[1] https://wiki.mozilla.org/Modules/All#Build_and_Release_Tools
[2] https://dxr.mozilla.org/mozilla-central/source/browser/config/mozconfigs/whitelist#45

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8914240 [details]
Bug 1404823 - Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/185560/diff/1-2/

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8914240 [details]
Bug 1404823 - Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary

https://reviewboard.mozilla.org/r/185560/#review190704

Comment 5

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/projects/oak/rev/46cdf85f143c73087ba63e1b642eda20a8b490bf
Bug 1404823 - Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary r?rail

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8914240 [details]
Bug 1404823 - Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/185560/diff/2-3/

Comment 7

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/75fd371db04b2cbffeb01efea4f5b5b52250b921
Bug 1404823 - Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary r=rail

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out for build bustages on ../build/compare-mozconfig/compare-mozconfigs-wrapper.py::TestCompareMozconfigs::test_compare_mozconfigs

Treeheder link with the push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8d8bb8542b3d23f2b590f9c2b1cb9215219527df&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/d94f6fad91e42260b0a93f097bb38d93aea41970

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=152720370&repo=mozilla-inbound&lineNumber=30264

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out for build bustages on ../build/compare-mozconfig/compare-mozconfigs-wrapper.py::TestCompareMozconfigs::test_compare_mozconfigs

Treeheder link with the push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8d8bb8542b3d23f2b590f9c2b1cb9215219527df&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/d94f6fad91e42260b0a93f097bb38d93aea41970

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=152720370&repo=mozilla-inbound&lineNumber=30264

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bca6b0df7212
Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary r=rail

Comment 11

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/projects/oak/rev/2d0c9b0ed55237451749e0ab720007b9c510b4ca
try to unbreak the oak branch by backporting the fix that landed in bug 1404823

Comment 12

[Dorel Luca [:dluca]]

 Backed out changeset bca6b0df7212 (bug 1404823) for failing Browser-chrome on toolkit/xre/test/browser_checkdllblockliststate.js on a CLOSED TREE 

https://treeherder.mozilla.org/logviewer.html#?job_id=152893594&repo=mozilla-inbound&lineNumber=6086

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e66190460ee40688bbf87cdac4489dac9d7fcf3

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=40eb00c21e7c776d4781c28e88a9b0917b4396ce&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=152893594

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d461768da724
Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary r=rail

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d461768da724