Closed Bug 1404832 Opened 2 years ago Closed 2 years ago

Migrate browser_webconsole_bug_613642_prune_scroll.js to the new frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: nchevobbe, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(2 files)

No description provided.
Priority: -- → P3
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8949778 [details]
Bug 1404832 - remove unused support file;

https://reviewboard.mozilla.org/r/219080/#review224864
Attachment #8949778 - Flags: review?(nchevobbe) → review+
Comment on attachment 8949777 [details]
Bug 1404832 - rename and enable browser_webconsole_loglimit.js;

https://reviewboard.mozilla.org/r/219078/#review224868

Looks good, and much simpler, thanks julian

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_loglimit.js:26
(Diff revision 1)
> -  yield waitForMessages({
> -    webconsole: hud,
> -    messages: [{
> +  ok(!findMessage(hud, "test message [0]"), "Message 0 has been pruned");
> +  ok(!findMessage(hud, "test message [9]"), "Message 9 has been pruned");
> +  ok(findMessage(hud, "test message [10]"), "Message 10 is still displayed");

just to be extra confident, could we assert findMessages(hud, "").length === 150
?

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_loglimit.js:37
(Diff revision 1)
>      content.console.log("hello world");
>    });
> +  await onMessage;
>  
> -  yield waitForMessages({
> -    webconsole: hud,
> +  ok(!findMessage(hud, "test message [10]"), "Message 10 has been pruned");
> +  ok(findMessage(hud, "test message [11]"), "Message 11 is still displayed");

same here about asserting the total number of messages displayed
Attachment #8949777 - Flags: review?(nchevobbe) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e36136d7dda
rename and enable browser_webconsole_loglimit.js;r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/0f14e2c1aba3
remove unused support file;r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/1e36136d7dda
https://hg.mozilla.org/mozilla-central/rev/0f14e2c1aba3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.