1404832 - Migrate browser_webconsole_bug_613642_prune_scroll.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1404832 - rename and enable browser_webconsole_loglimit.js;

The scrolling part of the test already seems covered in
browser_webconsole_scroll.js

Review commit: https://reviewboard.mozilla.org/r/219078/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219078/

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1404832 - remove unused support file;

The test browser_webconsole_bug_644419_log_limits.js was marked
as irrelevant for the new console frontend, but the support file
was still copied to the new frontend folder.

Review commit: https://reviewboard.mozilla.org/r/219080/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219080/

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8949778 [details]
Bug 1404832 - remove unused support file;

https://reviewboard.mozilla.org/r/219080/#review224864

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8949777 [details]
Bug 1404832 - rename and enable browser_webconsole_loglimit.js;

https://reviewboard.mozilla.org/r/219078/#review224868

Looks good, and much simpler, thanks julian

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_loglimit.js:26
(Diff revision 1)
> -  yield waitForMessages({
> -    webconsole: hud,
> -    messages: [{
> +  ok(!findMessage(hud, "test message [0]"), "Message 0 has been pruned");
> +  ok(!findMessage(hud, "test message [9]"), "Message 9 has been pruned");
> +  ok(findMessage(hud, "test message [10]"), "Message 10 is still displayed");

just to be extra confident, could we assert findMessages(hud, "").length === 150
?

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_loglimit.js:37
(Diff revision 1)
>      content.console.log("hello world");
>    });
> +  await onMessage;
>  
> -  yield waitForMessages({
> -    webconsole: hud,
> +  ok(!findMessage(hud, "test message [10]"), "Message 10 has been pruned");
> +  ok(findMessage(hud, "test message [11]"), "Message 11 is still displayed");

same here about asserting the total number of messages displayed

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8949777 [details]
Bug 1404832 - rename and enable browser_webconsole_loglimit.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219078/diff/1-2/

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 8949778 [details]
Bug 1404832 - remove unused support file;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219080/diff/1-2/

Comment 7

[Julian Descottes [:jdescottes]]

Thanks for the review, applied the comments. New try https://treeherder.mozilla.org/#/jobs?repo=try&revision=4642935941f58ca9e8a2995f1bbc058c26f6c230

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e36136d7dda
rename and enable browser_webconsole_loglimit.js;r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/0f14e2c1aba3
remove unused support file;r=nchevobbe

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1e36136d7dda
https://hg.mozilla.org/mozilla-central/rev/0f14e2c1aba3