Status

enhancement
RESOLVED FIXED
2 years ago
11 months ago

People

(Reporter: jdescottes, Assigned: jlast)

Tracking

unspecified
Firefox 58
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Recurring debugger bundle updates for DevTools.

Let's try to reuse the same bug with leave-open and see if this is inconvenient or not. (When we automate this process, I'd prefer to go back to dedicated bugs for each bundle drop)
Reporter

Comment 1

2 years ago
Posted patch debugger-bundle-update 09/29 (obsolete) — Splinter Review
(just moved the patch from Bug 1403736 here)
Reporter

Comment 2

2 years ago
(In reply to Jason Laster [:jlast] from Bug 1403736 comment #18)
> Here's the release diff:
> https://github.com/devtools-html/debugger.html/compare/9fe3c952d5d4c2f106b...
> 2b18094c
> And the release PR: https://github.com/devtools-html/debugger.html/pull/4214

That's great to have this info here! Really helps, thank you.

(In reply to Jason Laster [:jlast] from Bug 1403736 comment #17)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=6c976a044878da6c1fc5dacc2f9116605f4a4a27

Test failed:
  devtools/client/debugger/test/mochitest/browser_dbg_scripts-switching-03.js | A promise chain failed to handle a rejection: Error: No localization found for [errorLoadingText2]

Should be updated to errorLoadingText3
Reporter

Comment 3

2 years ago
Comment on attachment 8914247 [details] [diff] [review]
debugger-bundle-update 09/29

Review of attachment 8914247 [details] [diff] [review]:
-----------------------------------------------------------------

R+ with my comments addressed + green try.

::: devtools/client/debugger/new/test/mochitest/browser.ini
@@ +63,5 @@
>  [browser_dbg-breakpoints-reloading.js]
>  skip-if = true # Bug 1383576
>  [browser_dbg-breakpoints-cond.js]
>  [browser_dbg-call-stack.js]
>  [browser_dbg-expressions.js]

This file ([browser_dbg-expressions-error.js]) is still in the source tree. Either `skip-if=true` it with a comment or remove it from the tree.

::: devtools/client/locales/en-US/debugger.properties
@@ +557,2 @@
>  # viewer when there is an error loading a file
> +errorLoadingText3=Error loading this URI: %S

Update two references to errorLoadingText2 in the old debugger:
- devtools/client/debugger/debugger-view.js
- devtools/client/debugger/test/mochitest/browser_dbg_scripts-switching-03.js
Attachment #8914247 - Flags: review+
Assignee

Comment 4

2 years ago
Posted patch 9-29-2.patch (obsolete) — Splinter Review
Attachment #8914247 - Attachment is obsolete: true
Reporter

Comment 6

2 years ago
Comment on attachment 8914298 [details] [diff] [review]
9-29-2.patch

Review of attachment 8914298 [details] [diff] [review]:
-----------------------------------------------------------------

Please set the new bug number in the commit message.
Attachment #8914298 - Flags: review+
Assignee

Comment 7

2 years ago
Posted patch 9-29-3.patchSplinter Review
Attachment #8914298 - Attachment is obsolete: true
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 8

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec4e1ade8cf2
Update debugger frontend (9/29/2017). r=jdescottes
Keywords: checkin-needed

Comment 11

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a42ecd2ce80c
Update debugger frontend (9/29/2017). r=jdescottes
Reporter

Updated

2 years ago
Flags: needinfo?(wkocher)
Blocks: 1405128
Reporter

Updated

2 years ago
Alias: debugger-updates
Can this bug be closed now? I see comment 0 prefers to keep one bug for recurrent updates, but in terms of tracking regressions this will be problematic.
Flags: needinfo?(jlaster)
Sure, closing. We are not using this bug. Instead we have one bug per release, under the meta https://bugzilla.mozilla.org/show_bug.cgi?id=debugger-bundle-updates
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Flags: needinfo?(jlaster)
Keywords: leave-open
Resolution: --- → INVALID
Resolution: INVALID → FIXED
Target Milestone: --- → Firefox 58

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.