1404849 - Migrate browser_webconsole_bug_632347_iterators_generators.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1404849 - migrate mochitest for generators autocompletion to xpcshell;

Review commit: https://reviewboard.mozilla.org/r/211690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211690/

Comment 2

[Julian Descottes [:jdescottes]]

For this one, the existing test checks two things:
- that js-property-provider does not run a generator's next() method when retrieving autocomplete suggestions
- that a generator is displayed as "Generator" in the variables view

I think the first part is more suited to be tested in the dedicated xpc-shell test for js-property-provider.
For the second part we could either have a very simple test where we log a generator, expand the Object Inspector and check that the generator has a display name of "Generator" ... or we could add a new reps test dedicated to generators. Let me know what you prefer. 

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=229f7dea0a2fc9b8ab370448e9ef86347623ee4e

Comment 3

[Julian Descottes [:jdescottes]]

This is similar to Bug 1406841, where I migrated the existing test. I was concerned that using a Sandbox might not cover all use cases compared to using a real window object.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

I agree about creating a Reps test for the generator.
I filed an issue for this https://github.com/devtools-html/devtools-core/issues/890

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8941376 [details]
Bug 1404849 - migrate mochitest for generators autocompletion to xpcshell;

https://reviewboard.mozilla.org/r/211690/#review217472

This looks good to me, thanks Julian

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48cb9676ec2c
migrate mochitest for generators autocompletion to xpcshell;r=nchevobbe

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/48cb9676ec2c