1404855 - Theming API - Add tests for windowId parameter on the browser UI

Status: NEW

(WebExtensions :: Themes, defect, P3)

Comment 1

[Tim Nguyen :ntim]

Bug 1349944 tests whether the windowId parameter works well on the WebExtension side of things.

What's left to add are tests for whether the properties are properly applied on the browser UI itself.

Comment 2

[Mike de Boer [:mikedeboer]]

P5's clearly the wrong value; we need a stable base to expand the Theming API from, so a regression test like this is essential.

We can also ensure that bug 1387737 won't happen again.

Comment 3

[Mike de Boer [:mikedeboer]]

Hmm, seems like https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_onUpdated.js is already what we need.
Thanks, Tim!

Comment 4

[Tim Nguyen :ntim]

(In reply to Mike de Boer [:mikedeboer] from comment #3)
> Hmm, seems like
> https://searchfox.org/mozilla-central/source/toolkit/components/extensions/
> test/browser/browser_ext_themes_dynamic_onUpdated.js is already what we need.
> Thanks, Tim!

This only tests whether `windowId` works well on the WebExtension side, but not on the browser UI side. There are actually absolutely no tests testing whether the CSS variables are set correctly per-window, or that those per-window CSS variables are in sync with the WebExtension getCurrent() method.

Comment 5

[Mike de Boer [:mikedeboer]]

Ah, thanks for the note Tim! I'll work on those tests then.

Comment 6

[Tim Nguyen :ntim]

Welp, this just bit us in bug 1451586.

Comment 7

[Tim Nguyen :ntim]

https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js

is an example of per-window theme test for the new tab page.

It can easily be adjusted for basic accentcolor/textcolor testing.

Comment 8

[Mike de Boer [:mikedeboer]]

Not actively working on this, please feel free to take it when interested.