No description provided.
Bug 1349944 tests whether the windowId parameter works well on the WebExtension side of things. What's left to add are tests for whether the properties are properly applied on the browser UI itself.
Summary: Theming API - Add tests for windowId parameter → Theming API - Add tests for windowId parameter on the browser UI
Depends on: dark-theme-darkening
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
P5's clearly the wrong value; we need a stable base to expand the Theming API from, so a regression test like this is essential. We can also ensure that bug 1387737 won't happen again.
Priority: P5 → P2
Hmm, seems like https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_onUpdated.js is already what we need. Thanks, Tim!
Assignee: mdeboer → ntim.bugs
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(In reply to Mike de Boer [:mikedeboer] from comment #3) > Hmm, seems like > https://searchfox.org/mozilla-central/source/toolkit/components/extensions/ > test/browser/browser_ext_themes_dynamic_onUpdated.js is already what we need. > Thanks, Tim! This only tests whether `windowId` works well on the WebExtension side, but not on the browser UI side. There are actually absolutely no tests testing whether the CSS variables are set correctly per-window, or that those per-window CSS variables are in sync with the WebExtension getCurrent() method.
Ah, thanks for the note Tim! I'll work on those tests then.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: ntim.bugs → mdeboer
Status: REOPENED → ASSIGNED
Welp, this just bit us in bug 1451586.
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js is an example of per-window theme test for the new tab page. It can easily be adjusted for basic accentcolor/textcolor testing.
You need to log in before you can comment on or make changes to this bug.