Theming API - Add tests for windowId parameter on the browser UI

ASSIGNED
Assigned to

Status

defect
P2
normal
ASSIGNED
2 years ago
9 months ago

People

(Reporter: ntim, Assigned: mikedeboer)

Tracking

(Blocks 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

Reporter

Description

2 years ago
No description provided.
Assignee

Updated

2 years ago
Blocks: 1401691

Updated

2 years ago
Priority: -- → P5
Reporter

Comment 1

2 years ago
Bug 1349944 tests whether the windowId parameter works well on the WebExtension side of things.

What's left to add are tests for whether the properties are properly applied on the browser UI itself.
Reporter

Updated

2 years ago
Summary: Theming API - Add tests for windowId parameter → Theming API - Add tests for windowId parameter on the browser UI
Reporter

Updated

2 years ago
Blocks: 1342712, themingapi-polish
No longer blocks: themingapi
Reporter

Updated

a year ago
Assignee: ntim.bugs → nobody
Assignee

Updated

a year ago
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Assignee

Comment 2

a year ago
P5's clearly the wrong value; we need a stable base to expand the Theming API from, so a regression test like this is essential.

We can also ensure that bug 1387737 won't happen again.
Priority: P5 → P2
Assignee

Comment 3

a year ago
Hmm, seems like https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_onUpdated.js is already what we need.
Thanks, Tim!
Assignee: mdeboer → ntim.bugs
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Reporter

Comment 4

a year ago
(In reply to Mike de Boer [:mikedeboer] from comment #3)
> Hmm, seems like
> https://searchfox.org/mozilla-central/source/toolkit/components/extensions/
> test/browser/browser_ext_themes_dynamic_onUpdated.js is already what we need.
> Thanks, Tim!

This only tests whether `windowId` works well on the WebExtension side, but not on the browser UI side. There are actually absolutely no tests testing whether the CSS variables are set correctly per-window, or that those per-window CSS variables are in sync with the WebExtension getCurrent() method.
Flags: needinfo?(mdeboer)
Assignee

Comment 5

a year ago
Ah, thanks for the note Tim! I'll work on those tests then.
Status: RESOLVED → REOPENED
Flags: needinfo?(mdeboer)
Resolution: FIXED → ---
Assignee

Updated

a year ago
Assignee: ntim.bugs → mdeboer
Status: REOPENED → ASSIGNED
Reporter

Comment 6

a year ago
Welp, this just bit us in bug 1451586.

Updated

11 months ago
Product: Toolkit → WebExtensions
Reporter

Updated

11 months ago
No longer blocks: dark-theme-darkening
Reporter

Updated

9 months ago
Blocks: 1486592
Reporter

Comment 7

9 months ago
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js

is an example of per-window theme test for the new tab page.

It can easily be adjusted for basic accentcolor/textcolor testing.
You need to log in before you can comment on or make changes to this bug.