1404896 - Separate the pointer lock implementations from GenerateMouseEnterExit to new functions.

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement)

Description

[Ming-Chou Shih [:stone]]

Separate this from bug 1400143

It's not necessary to bundle the following logic to GenerateMouseEnterExit
1. update the ESM::sLastRefPoint
2. update event's mLastRefPoint
3. synthesize mouse move to bring the pointer to the center of window

And this can make it easier to reuse them for handling pointer events.

Comment 1

[Ming-Chou Shih [:stone]]

Attachment: Separate the pointer lock implementations from GenerateMouseEnterExit to new functions.

Comment 2

[Ming-Chou Shih [:stone]]

Comment on attachment 8914323 [details] [diff] [review]
Separate the pointer lock implementations from GenerateMouseEnterExit to new functions.

Could you help me to review if the methods names make sense to you? Thanks.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8914323 [details] [diff] [review]
Separate the pointer lock implementations from GenerateMouseEnterExit to new functions.

>+  /**
>+   * Update the attribute mLastRefPoint of the mouse event. It should be
>+   *     the center of the window while the pointer is locked.
>+   *     the same value as mRefPoint while there is no last known mRefPoint.
"last known mRefPoint" doesn't really mean anything. But no known last ref point or so.

>+   *     the same value as the last known mRefPoint.
>+   */
>+  static void UpdateLastRefPointOfMouseEvent(WidgetMouseEvent* aMouseEvent);
>+
>+  static void ResetPointerToWindowCenterWhilePointerLocked(
>+                WidgetMouseEvent* aMouseEvent);
>+
>+  // Update the last known mRefPoint with the current mRefPoint.
I don't understand this comment. The method doesn't update any mRefPoint.
It updates the last known ref point with the current mRefPoint.

Comment 4

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b6249ee7bfeb8181ed4b3f40febeba1f145913c

Comment 5

[Ming-Chou Shih [:stone]]

Attachment: Separate the pointer lock implementations from GenerateMouseEnterExit to new functions.

Updated comments

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bb7fc4b9991
Separate the pointer lock implementations from GenerateMouseEnterExit to new functions. r=smaug.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0bb7fc4b9991