1404911 - delete called on 'nss_test::AeadCipher' that is abstract but has non-virtual destructor

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Franziskus Kiefer [:franziskus]]

/usr/lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:76:2: error: delete called on 'nss_test::AeadCipher' that is abstract but has non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
        delete __ptr;
        ^
/usr/lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:236:4: note: in instantiation of member function 'std::default_delete<nss_test::AeadCipher>::operator()' requested here
          get_deleter()(__ptr);
          ^
../../gtests/ssl_gtest/tls_protect.h:61:3: note: in instantiation of member function 'std::unique_ptr<nss_test::AeadCipher, std::default_delete<nss_test::AeadCipher> >::~unique_ptr' requested here
  TlsCipherSpec() : aead_() {}
  ^

Comment 1

[Phabricator Automation]

Comment on attachment 8914302 [details]
Bug 1404911 - Make AEAD destructor virtual to fix fuzzing build on TC

Martin Thomson [:mt:] has approved the revision.

https://phabricator.services.mozilla.com/D90#1941

Comment 2

[Franziskus Kiefer [:franziskus]]

https://hg.mozilla.org/projects/nss/rev/ffe09c48221c90d66411834e7da1f852fd2af24a