Closed Bug 1405004 Opened 3 years ago Closed 3 years ago

Unused DOCUMENT_POSITION_DISCONNECTED constant in testing/marionette/element.js

Categories

(Testing :: Marionette, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8914369 [details]
Bug 1405004 - Remove unused imports from testing/marionette/element.js.

https://reviewboard.mozilla.org/r/185640/#review190756

I wonder if we could lint for those things.
Attachment #8914369 - Flags: review?(hskupin) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/557a4ad274ed
Remove unused imports from testing/marionette/element.js. r=whimboo
(In reply to Henrik Skupin (:whimboo) from comment #2)

> I wonder if we could lint for those things.

That would be nice, but in an interpreted language I guess that
would be hard.  Maybe https://eslint.org/docs/rules/no-unused-vars
would be helpful?  I’m not sure how good it is.
https://hg.mozilla.org/mozilla-central/rev/557a4ad274ed
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
(In reply to Andreas Tolfsen ‹:ato› from comment #4)
> (In reply to Henrik Skupin (:whimboo) from comment #2)
> 
> > I wonder if we could lint for those things.
> 
> That would be nice, but in an interpreted language I guess that
> would be hard.  Maybe https://eslint.org/docs/rules/no-unused-vars
> would be helpful?  I’m not sure how good it is.

Filed https://bugzil.la/1405279 to follow up on this.
You need to log in before you can comment on or make changes to this bug.