Open
Bug 1405007
Opened 7 years ago
Updated 2 years ago
[META] Remove old compatibility code to support old backends
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(Not tracked)
NEW
People
(Reporter: ochameau, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: meta)
Over time we keep adding compatibiliy code in the client codebase in order to support remote connection to runtime having old version of backend/actors. A good example is bug 990137. We introduced "conditionalBreakpoints" trait on the root actor over here: http://searchfox.org/mozilla-central/rev/298033405057ca7aa5099153797467eceeaa08b5/devtools/server/actors/root.js#139-140 // Whether conditional breakpoints are supported conditionalBreakpoints: true, It landed in Firefox 31, 4 years ago via bug 812172. So all Firefoxes since version 31 do not need this compatibility check anymore. Current oldest supported version is Firefox ESR 52. So we should be able to remove such compatiblity code. Let's keep this bug always open and be a META for all such removal.
Comment 1•7 years ago
|
||
Thanks for this initiative! This would be a good time to settle on a convention to annotate new compatibility code that lands from now on @backward-compatibility {max version that requires the related code} ?
Keywords: meta
Updated•7 years ago
|
Priority: -- → P3
Updated•6 years ago
|
Product: Firefox → DevTools
Reporter | ||
Comment 2•6 years ago
|
||
Here is a quick list of search queries in order to spot backward compatibility code: * actorHasMethod() https://searchfox.org/mozilla-central/search?q=ActorHasmethod&case=false®exp=true&path=devtools * hasActor https://searchfox.org/mozilla-central/search?q=HasActor&case=false®exp=true&path=devtools * Traits https://searchfox.org/mozilla-central/search?q=.traits&case=false®exp=true&path=devtools * getTrait https://searchfox.org/mozilla-central/search?q=GetTrait&case=false®exp=true&path=devtools * FFxx strings : https://searchfox.org/mozilla-central/search?q=%5CsFF%5Cd%2B&case=false®exp=true&path=devtools
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•