Closed Bug 1405030 Opened 7 years ago Closed 7 years ago

Fix loading of matrix.js

Categories

(Chat Core :: Matrix, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 58

People

(Reporter: fredw, Assigned: fredw)

Details

Attachments

(1 file)

Loading matrix.js currently fails:
- commonjs/toolkit/loader.js no longer exists
- We got an error "MatrixSDK is undefined"
Attached patch PatchSplinter Review
Attachment #8914399 - Flags: review?(clokep)
Comment on attachment 8914399 [details] [diff] [review]
Patch

Review of attachment 8914399 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable, but kind of fragile to include things from devtools. Any idea when we'll be able to load modules directly?
Attachment #8914399 - Flags: review?(clokep) → review+
Pushed by clokep@gmail.com:
https://hg.mozilla.org/comm-central/rev/b2ecd51acb47
Fix loading of matrix.js r=clokep
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: