1405063 - Adding a tab in the TabBar should be able to take an index to specify where to add the tab

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

The ToolSidebar and TabBar should be able to take an index to specify where in the TabBar the new tab can be added. 

I have an use case where I am pushing and popping out the Rules view in Bug 1369945 to create a 3 pane inspector view. I need to be able to specify an index when adding a tab so that the Rules view can be inserted back to be the first tab in the ToolSidebar in the Inspector.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1405063 - Adding a tab in the TabBar should be able to take an index to specify where to add the tab.

Review commit: https://reviewboard.mozilla.org/r/185756/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185756/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8914443 [details]
Bug 1405063 - Adding a tab in the TabBar should be able to take an index to specify where to add the tab.

https://reviewboard.mozilla.org/r/185756/#review191074

Looks reasonable, thanks!

R+ assuming try is green and my comment is resolved.

Honza

::: devtools/client/shared/components/tabs/TabBar.js:82
(Diff revision 1)
>    },
>  
>    // Public API
>  
> -  addTab: function (id, title, selected = false, panel, url) {
> +  addTab: function (id, title, selected = false, panel, url, index) {
>      let tabs = this.state.tabs.slice();

We can provide default -1 for the index argument.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfde202ada8a
Adding a tab in the TabBar should be able to take an index to specify where to add the tab. r=honza

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bfde202ada8a